<div dir="ltr">FYI I had to revert this in r281562 because of:<div><br></div><div>* <a href="http://llvm.org/PR30341">http://llvm.org/PR30341</a> which breaks the LLVM build.</div><div>* <a href="http://llvm.org/PR30391">http://llvm.org/PR30391</a> which breaks ABI compatibility when libc++.so is compiled with GCC.</div><div><br></div><div>I'm working on fixing these issues so that this patch may be recommitted. The GCC issue</div><div>also made worse by r278356 but I don't think we need to revert it (at least right now).</div><div><br></div><div>/Eric</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 8, 2016 at 8:31 AM, Aditya Kumar via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hiraditya<br>
Date: Thu Sep  8 09:31:44 2016<br>
New Revision: 280944<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280944&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=280944&view=rev</a><br>
Log:<br>
Added 'inline' attribute to basic_string's destructor<br>
<br>
Author: laxmansole<br>
<br>
Reviewers: howard.hinnant<br>
           mclow.lists<br>
Subscribers: EricWF, flyingforyou, evandro<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D22834" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D22834</a><br>
<br>
Currently basic_string's destructor is not getting inlined. So adding 'inline' attribute to ~basic_string().<br>
Worked in collaboration with Aditya Kumar.<br>
<br>
Modified:<br>
    libcxx/trunk/include/string<br>
<br>
Modified: libcxx/trunk/include/string<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=280944&r1=280943&r2=280944&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/include/<wbr>string?rev=280944&r1=280943&<wbr>r2=280944&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/include/string (original)<br>
+++ libcxx/trunk/include/string Thu Sep  8 09:31:44 2016<br>
@@ -1798,6 +1798,7 @@ basic_string<_CharT, _Traits, _Allocator<br>
 #endif  // _LIBCPP_HAS_NO_GENERALIZED_<wbr>INITIALIZERS<br>
<br>
 template <class _CharT, class _Traits, class _Allocator><br>
+inline _LIBCPP_INLINE_VISIBILITY<br>
 basic_string<_CharT, _Traits, _Allocator>::~basic_string()<br>
 {<br>
 #if _LIBCPP_DEBUG_LEVEL >= 2<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>