<div dir="ltr">standalone and limit-debug-info are the same functionality - -fstandalone-debug is the more modern and apt description, so perhaps just keep that one & drop/don't provide -flimit-debug-info (since there's no real need to be backwards compatible in the flag support in clang-cl, I expect)?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 9, 2016 at 9:51 AM Reid Kleckner via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br class="gmail_msg">
Date: Fri Sep  9 11:42:50 2016<br class="gmail_msg">
New Revision: 281056<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281056&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=281056&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Make -fstandalone-debug and -flimit-debug-info available in clang-cl<br class="gmail_msg">
<br class="gmail_msg">
Our limited debug info optimizations are breaking down at DLL<br class="gmail_msg">
boundaries, so we're going to evaluate the size impact of these<br class="gmail_msg">
settings, and possibly change the default.<br class="gmail_msg">
<br class="gmail_msg">
Users should be able to override our settings, though.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    cfe/trunk/include/clang/Driver/Options.td<br class="gmail_msg">
    cfe/trunk/test/Driver/cl-options.c<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/include/clang/Driver/Options.td<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=281056&r1=281055&r2=281056&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=281056&r1=281055&r2=281056&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/include/clang/Driver/Options.td (original)<br class="gmail_msg">
+++ cfe/trunk/include/clang/Driver/Options.td Fri Sep  9 11:42:50 2016<br class="gmail_msg">
@@ -1138,12 +1138,12 @@ def fstack_protector_strong : Flag<["-"]<br class="gmail_msg">
   HelpText<"Use a strong heuristic to apply stack protectors to functions">;<br class="gmail_msg">
 def fstack_protector : Flag<["-"], "fstack-protector">, Group<f_Group>,<br class="gmail_msg">
   HelpText<"Enable stack protectors for functions potentially vulnerable to stack smashing">;<br class="gmail_msg">
-def fstandalone_debug : Flag<["-"], "fstandalone-debug">, Group<f_Group>,<br class="gmail_msg">
+def fstandalone_debug : Flag<["-"], "fstandalone-debug">, Group<f_Group>, Flags<[CoreOption]>,<br class="gmail_msg">
   HelpText<"Emit full debug info for all types used by the program">;<br class="gmail_msg">
-def fno_standalone_debug : Flag<["-"], "fno-standalone-debug">, Group<f_Group>,<br class="gmail_msg">
+def fno_standalone_debug : Flag<["-"], "fno-standalone-debug">, Group<f_Group>, Flags<[CoreOption]>,<br class="gmail_msg">
   HelpText<"Limit debug information produced to reduce size of debug binary">;<br class="gmail_msg">
-def flimit_debug_info : Flag<["-"], "flimit-debug-info">, Alias<fno_standalone_debug>;<br class="gmail_msg">
-def fno_limit_debug_info : Flag<["-"], "fno-limit-debug-info">, Alias<fstandalone_debug>;<br class="gmail_msg">
+def flimit_debug_info : Flag<["-"], "flimit-debug-info">, Flags<[CoreOption]>, Alias<fno_standalone_debug>;<br class="gmail_msg">
+def fno_limit_debug_info : Flag<["-"], "fno-limit-debug-info">, Flags<[CoreOption]>, Alias<fstandalone_debug>;<br class="gmail_msg">
 def fstrict_aliasing : Flag<["-"], "fstrict-aliasing">, Group<f_Group>,<br class="gmail_msg">
   Flags<[DriverOption, CoreOption]>;<br class="gmail_msg">
 def fstrict_enums : Flag<["-"], "fstrict-enums">, Group<f_Group>, Flags<[CC1Option]>,<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/test/Driver/cl-options.c<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=281056&r1=281055&r2=281056&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=281056&r1=281055&r2=281056&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/test/Driver/cl-options.c (original)<br class="gmail_msg">
+++ cfe/trunk/test/Driver/cl-options.c Fri Sep  9 11:42:50 2016<br class="gmail_msg">
@@ -518,6 +518,8 @@<br class="gmail_msg">
 // RUN:     -resource-dir \<br class="gmail_msg">
 // RUN:     -Wunused-variable \<br class="gmail_msg">
 // RUN:     -fmacro-backtrace-limit=0 \<br class="gmail_msg">
+// RUN:     -fstandalone-debug \<br class="gmail_msg">
+// RUN:     -flimit-debug-info \<br class="gmail_msg">
 // RUN:     -Werror /Zs -- %s 2>&1<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div>