<div dir="ltr">Does that actually need a virtual dtor? The type erasure handling in shared_ptr would handle it so long as each instance is constructed with the derived type (looks like it probably is - make_shared used consistently) & we should get a warning (or could make the base dtor protected non-virtual to ensure an error) if we miss that?<br><br>But I can understand that it's perhaps nice to do even if we could thread that delicate needle. Just curious.</div><br><div class="gmail_quote"><div dir="ltr">On Sun, Sep 11, 2016 at 11:59 PM Richard Smith via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rsmith<br class="gmail_msg">
Date: Mon Sep 12 01:51:11 2016<br class="gmail_msg">
New Revision: 281198<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281198&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=281198&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Add virtual destructor (necessary due to the switch to shared_ptr).<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp?rev=281198&r1=281197&r2=281198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp?rev=281198&r1=281197&r2=281198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp Mon Sep 12 01:51:11 2016<br class="gmail_msg">
@@ -911,6 +911,7 @@ namespace {<br class="gmail_msg">
 struct DiagText {<br class="gmail_msg">
   struct Piece {<br class="gmail_msg">
     virtual void print(std::vector<std::string> &RST) = 0;<br class="gmail_msg">
+    virtual ~Piece() {}<br class="gmail_msg">
   };<br class="gmail_msg">
   struct TextPiece : Piece {<br class="gmail_msg">
     StringRef Role;<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div>