<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">The case that failed on the build not was something like<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">-o blah.o -x c++ -o system /.../<a href="http://llvm.org/">llvm.org/.</a>..<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">... where the first line of the old pattern matched up to the .o in
<a href="http://llvm.org">llvm.org</a>, causing the second line to fail to match.<o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">That suggests the .* behavior is 'greedy' (matching as much as possible rather than as little as possible) which is probably not the behavior we want (clearly
not the behavior the test author expected). I'll file a bug.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> metafoo@gmail.com [mailto:metafoo@gmail.com]
<b>On Behalf Of </b>Richard Smith<br>
<b>Sent:</b> Tuesday, August 30, 2016 9:55 AM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> cfe-commits<br>
<b>Subject:</b> RE: r280057 - Combine two FileCheck patterns to prevent overzealous matching of .*<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<div>
<p class="MsoNormal">On 30 Aug 2016 9:45 am, "Robinson, Paul" <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<o:p></o:p></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org">cfe-commits-bounces@lists.llvm.org</a>] On Behalf Of<br>
> Richard Smith via cfe-commits<br>
> Sent: Monday, August 29, 2016 10:15 PM<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> Subject: r280057 - Combine two FileCheck patterns to prevent overzealous<br>
> matching of .*<br>
><br>
> Author: rsmith<br>
> Date: Tue Aug 30 00:14:38 2016<br>
> New Revision: 280057<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280057&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=280057&view=rev</a><br>
> Log:<br>
> Combine two FileCheck patterns to prevent overzealous matching of .*<br>
><br>
> Modified:<br>
> cfe/trunk/test/Driver/modules-ts.cpp<br>
><br>
> Modified: cfe/trunk/test/Driver/modules-ts.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/modules-" target="_blank">
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/modules-</a><br>
> ts.cpp?rev=280057&r1=280056&r2=280057&view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- cfe/trunk/test/Driver/modules-ts.cpp (original)<br>
> +++ cfe/trunk/test/Driver/modules-ts.cpp Tue Aug 30 00:14:38 2016<br>
> @@ -23,8 +23,7 @@<br>
> // CHECK-USE: -cc1<br>
> // CHECK-USE-SAME: -emit-obj<br>
> // CHECK-USE-SAME: -fmodule-file={{.*}}.pcm<br>
> -// CHECK-USE-SAME: -o {{.*}}.o<br>
> -// CHECK-USE-SAME: -x c++<br>
> +// CHECK-USE-SAME: -o {{.*}}.o {{.*}}-x c++<o:p></o:p></p>
</div>
<p class="MsoNormal">Sorry--how are these not doing the same thing?<br>
That is, what input will incorrectly fail with the old checks?<o:p></o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The case that failed on the build not was something like<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-o blah.o -x c++ -o system /.../<a href="http://llvm.org/">llvm.org/.</a>..<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">... where the first line of the old pattern matched up to the .o in
<a href="http://llvm.org">llvm.org</a>, causing the second line to fail to match.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Thanks,<br>
--paulr<o:p></o:p></p>
<div>
<p class="MsoNormal"><br>
> // CHECK-USE-SAME: modules-ts.cpp<br>
><br>
> // Check combining precompile and compile steps works.<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>