<div><div class="gmail_extra"><div class="gmail_quote">On 30 Aug 2016 9:45 am, "Robinson, Paul" <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="elided-text"><br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org">cfe-commits-bounces@<wbr>lists.llvm.org</a>] On Behalf Of<br>
> Richard Smith via cfe-commits<br>
> Sent: Monday, August 29, 2016 10:15 PM<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> Subject: r280057 - Combine two FileCheck patterns to prevent overzealous<br>
> matching of .*<br>
><br>
> Author: rsmith<br>
> Date: Tue Aug 30 00:14:38 2016<br>
> New Revision: 280057<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280057&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=280057&view=rev</a><br>
> Log:<br>
> Combine two FileCheck patterns to prevent overzealous matching of .*<br>
><br>
> Modified:<br>
>     cfe/trunk/test/Driver/modules-<wbr>ts.cpp<br>
><br>
> Modified: cfe/trunk/test/Driver/modules-<wbr>ts.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/modules-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/test/Driver/<wbr>modules-</a><br>
> ts.cpp?rev=280057&r1=280056&<wbr>r2=280057&view=diff<br>
> ==============================<wbr>==============================<wbr>==============<br>
> ====<br>
> --- cfe/trunk/test/Driver/modules-<wbr>ts.cpp (original)<br>
> +++ cfe/trunk/test/Driver/modules-<wbr>ts.cpp Tue Aug 30 00:14:38 2016<br>
> @@ -23,8 +23,7 @@<br>
>  // CHECK-USE: -cc1<br>
>  // CHECK-USE-SAME: -emit-obj<br>
>  // CHECK-USE-SAME: -fmodule-file={{.*}}.pcm<br>
> -// CHECK-USE-SAME: -o {{.*}}.o<br>
> -// CHECK-USE-SAME: -x c++<br>
> +// CHECK-USE-SAME: -o {{.*}}.o {{.*}}-x c++<br>
<br>
</div>Sorry--how are these not doing the same thing?<br>
That is, what input will incorrectly fail with the old checks?<br></blockquote></div></div></div><div><br></div><div>The case that failed on the build not was something like</div><div><br></div><div>-o blah.o -x c++ -o system /.../<a href="http://llvm.org/.">llvm.org/.</a>..</div><div><br></div><div>... where the first line of the old pattern matched up to the .o in <a href="http://llvm.org">llvm.org</a>, causing the second line to fail to match.</div><div><br></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks,<br>
--paulr<br>
<div class="elided-text"><br>
>  // CHECK-USE-SAME: modules-ts.cpp<br>
><br>
>  // Check combining precompile and compile steps works.<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</div></blockquote></div><br></div></div>