<div dir="ltr">On Thu, Aug 11, 2016 at 9:58 AM, Saleem Abdulrasool via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: compnerd<br>
Date: Thu Aug 11 11:58:12 2016<br>
New Revision: 278357<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=278357&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=278357&view=rev</a><br>
Log:<br>
test: relax the FS test a slight bit to be more reliable<br>
<br>
Some filesystems track atime always. This relaxes the test to accept either a<br>
filesystem which does not accurately track atime or does track the atime<br>
accurately. This allows the test to pass on filesystems mounted with<br>
`strictatime` on Linux or on macOS.<br></blockquote><div><br></div><div>Thoughts on merging this to 3.9? It fixes tests on Linux.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Modified:<br>
libcxx/trunk/test/std/<wbr>experimental/filesystem/fs.op.<wbr>funcs/fs.op.last_write_time/<wbr>last_write_time.pass.cpp<br>
<br>
Modified: libcxx/trunk/test/std/<wbr>experimental/filesystem/fs.op.<wbr>funcs/fs.op.last_write_time/<wbr>last_write_time.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp?rev=278357&r1=278356&r2=278357&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/std/<wbr>experimental/filesystem/fs.op.<wbr>funcs/fs.op.last_write_time/<wbr>last_write_time.pass.cpp?rev=<wbr>278357&r1=278356&r2=278357&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/<wbr>experimental/filesystem/fs.op.<wbr>funcs/fs.op.last_write_time/<wbr>last_write_time.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/<wbr>experimental/filesystem/fs.op.<wbr>funcs/fs.op.last_write_time/<wbr>last_write_time.pass.cpp Thu Aug 11 11:58:12 2016<br>
@@ -158,7 +158,8 @@ TEST_CASE(get_last_write_time_<wbr>dynamic_en<br>
<br>
TEST_CHECK(ftime2 > ftime);<br>
TEST_CHECK(dtime2 > dtime);<br>
- TEST_CHECK(LastAccessTime(<wbr>file) == file_access_time);<br>
+ TEST_CHECK(LastAccessTime(<wbr>file) == file_access_time ||<br>
+ LastAccessTime(file) == Clock::to_time_t(ftime2));<br>
TEST_CHECK(LastAccessTime(dir) == dir_access_time);<br>
}<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>