<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I'm just curious: Is libcxx generally supposed to merely pass through what the operating system is returning (as in this case) or is is supposed to provide a common abstraction that behaves the same on all platforms?<div class=""><br class=""></div><div class="">-- adrian</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 10, 2016, at 8:23 PM, Eric Fiselier via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Thanks Matthias. My apoligies, I lost track of this patch.</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Aug 9, 2016 at 7:31 PM, Bruno Cardoso Lopes via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" class="gmail_quote">Thanks Matthias!<br class="">
<div class="HOEnZb"><div class="h5"><br class="">
On Tue, Aug 9, 2016 at 6:02 PM, Matthias Braun via cfe-commits<br class="">
<<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class="">
> Author: matze<br class="">
> Date: Tue Aug 9 20:02:28 2016<br class="">
> New Revision: 278191<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=278191&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=278191&view=rev</a><br class="">
> Log:<br class="">
> test/hard_link_count(): Fix test on darwin<br class="">
><br class="">
> The hard link count that stat reports are different between normal hfs and the<br class="">
> case sensitive variant. Accept both.<br class="">
><br class="">
> Modified:<br class="">
> libcxx/trunk/test/std/<wbr class="">experimental/filesystem/fs.op.<wbr class="">funcs/fs.op.hard_lk_ct/hard_<wbr class="">link_count.pass.cpp<br class="">
><br class="">
> Modified: libcxx/trunk/test/std/<wbr class="">experimental/filesystem/fs.op.<wbr class="">funcs/fs.op.hard_lk_ct/hard_<wbr class="">link_count.pass.cpp<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp?rev=278191&r1=278190&r2=278191&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/libcxx/trunk/test/std/<wbr class="">experimental/filesystem/fs.op.<wbr class="">funcs/fs.op.hard_lk_ct/hard_<wbr class="">link_count.pass.cpp?rev=<wbr class="">278191&r1=278190&r2=278191&<wbr class="">view=diff</a><br class="">
> ==============================<wbr class="">==============================<wbr class="">==================<br class="">
> --- libcxx/trunk/test/std/<wbr class="">experimental/filesystem/fs.op.<wbr class="">funcs/fs.op.hard_lk_ct/hard_<wbr class="">link_count.pass.cpp (original)<br class="">
> +++ libcxx/trunk/test/std/<wbr class="">experimental/filesystem/fs.op.<wbr class="">funcs/fs.op.hard_lk_ct/hard_<wbr class="">link_count.pass.cpp Tue Aug 9 20:02:28 2016<br class="">
> @@ -45,18 +45,27 @@ TEST_CASE(hard_link_count_for_<wbr class="">file)<br class="">
><br class="">
> TEST_CASE(hard_link_count_for_<wbr class="">directory)<br class="">
> {<br class="">
> - uintmax_t DirExpect = 3;<br class="">
> - uintmax_t Dir3Expect = 2;<br class="">
> + uintmax_t DirExpect = 3; // hard link from . .. and Dir2<br class="">
> + uintmax_t Dir3Expect = 2; // hard link from . ..<br class="">
> + uintmax_t DirExpectAlt = DirExpect;<br class="">
> + uintmax_t Dir3ExpectAlt = Dir3Expect;<br class="">
> #if defined(__APPLE__)<br class="">
> - DirExpect += 2;<br class="">
> - Dir3Expect += 1;<br class="">
> + // Filesystems formatted with case sensitive hfs+ behave unixish as<br class="">
> + // expected. Normal hfs+ filesystems report the number of directory<br class="">
> + // entries instead.<br class="">
> + DirExpectAlt = 5; // . .. Dir2 file1 file2<br class="">
> + Dir3Expect = 3; // . .. file5<br class="">
> #endif<br class="">
> - TEST_CHECK(hard_link_count(<wbr class="">StaticEnv::Dir) == DirExpect);<br class="">
> - TEST_CHECK(hard_link_count(<wbr class="">StaticEnv::Dir3) == Dir3Expect);<br class="">
> + TEST_CHECK(hard_link_count(<wbr class="">StaticEnv::Dir) == DirExpect ||<br class="">
> + hard_link_count(StaticEnv::<wbr class="">Dir) == DirExpectAlt);<br class="">
> + TEST_CHECK(hard_link_count(<wbr class="">StaticEnv::Dir3) == Dir3Expect ||<br class="">
> + hard_link_count(StaticEnv::<wbr class="">Dir3) == Dir3ExpectAlt);<br class="">
><br class="">
> std::error_code ec;<br class="">
> - TEST_CHECK(hard_link_count(<wbr class="">StaticEnv::Dir, ec) == DirExpect);<br class="">
> - TEST_CHECK(hard_link_count(<wbr class="">StaticEnv::Dir3, ec) == Dir3Expect);<br class="">
> + TEST_CHECK(hard_link_count(<wbr class="">StaticEnv::Dir, ec) == DirExpect ||<br class="">
> + hard_link_count(StaticEnv::<wbr class="">Dir, ec) == DirExpectAlt);<br class="">
> + TEST_CHECK(hard_link_count(<wbr class="">StaticEnv::Dir3, ec) == Dir3Expect ||<br class="">
> + hard_link_count(StaticEnv::<wbr class="">Dir3, ec) == Dir3ExpectAlt);<br class="">
> }<br class="">
> TEST_CASE(hard_link_count_<wbr class="">increments_test)<br class="">
> {<br class="">
><br class="">
><br class="">
> ______________________________<wbr class="">_________________<br class="">
> cfe-commits mailing list<br class="">
> <a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a><br class="">
<br class="">
<br class="">
<br class="">
</div></div><span class="HOEnZb"><font color="#888888" class="">--<br class="">
Bruno Cardoso Lopes<br class="">
<a href="http://www.brunocardoso.cc/" rel="noreferrer" target="_blank" class="">http://www.brunocardoso.cc</a><br class="">
</font></span><div class="HOEnZb"><div class="h5">______________________________<wbr class="">_________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a><br class="">
</div></div></blockquote></div><br class=""></div>
_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<br class=""></div></blockquote></div><br class=""></div></body></html>