<div dir="ltr">On Mon, Aug 8, 2016 at 1:20 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I didn't merge this one to 3.9 because the PACKAGE_VERSION seems to<br>
have always been trunk-svn, and it's at least not as misleading as<br>
having the wrong number.<br>
<br>
I wonder if PACKAGE_VERSION is actually important for anything in<br>
libcxx, libcxxabi and libunwind? At least for libcxx, the important<br>
version is _LIBCPP_VERSION in include/__config.<br></blockquote><div><br></div><div>I don't believe we use `PACKAGE_VERSION`.  I can see it being useful though as CPack would use that value.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks,<br>
Hans<br>
<div class="HOEnZb"><div class="h5"><br>
On Mon, Aug 8, 2016 at 11:01 AM, Eugene Zelenko via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: eugenezelenko<br>
> Date: Mon Aug  8 13:01:50 2016<br>
> New Revision: 278032<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=278032&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=278032&view=rev</a><br>
> Log:<br>
> CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.<br>
><br>
> Differential revision: <a href="https://reviews.llvm.org/D23091" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D23091</a><br>
><br>
> Modified:<br>
>     libcxx/trunk/CMakeLists.txt<br>
><br>
> Modified: libcxx/trunk/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=278032&r1=278031&r2=278032&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/<wbr>CMakeLists.txt?rev=278032&r1=<wbr>278031&r2=278032&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- libcxx/trunk/CMakeLists.txt (original)<br>
> +++ libcxx/trunk/CMakeLists.txt Mon Aug  8 13:01:50 2016<br>
> @@ -26,10 +26,10 @@ if (LIBCXX_BUILT_STANDALONE)<br>
>    project(libcxx CXX C)<br>
><br>
>    set(PACKAGE_NAME libcxx)<br>
> -  set(PACKAGE_VERSION trunk-svn)<br>
> +  set(PACKAGE_VERSION 4.0.0svn)<br>
>    set(PACKAGE_STRING "${PACKAGE_NAME} ${PACKAGE_VERSION}")<br>
>    set(PACKAGE_BUGREPORT "<a href="mailto:llvm-bugs@lists.llvm.org">llvm-bugs@lists.llvm.org</a>")<br>
> -endif ()<br>
> +endif()<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>