<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2016-08-06 5:45 GMT-07:00 Benjamin Kramer via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Sat Aug  6 07:45:16 2016<br>
New Revision: 277923<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277923&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=277923&view=rev</a><br>
Log:<br>
[ASTReader] Use real move semantics instead of emulating them in the copy ctor.<br>
<br>
No functionality change intended.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Serialization/<wbr>ASTReaderDecl.cpp<br>
<br>
Modified: cfe/trunk/lib/Serialization/<wbr>ASTReaderDecl.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReaderDecl.cpp?rev=277923&r1=277922&r2=277923&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/<wbr>Serialization/ASTReaderDecl.<wbr>cpp?rev=277923&r1=277922&r2=<wbr>277923&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/Serialization/<wbr>ASTReaderDecl.cpp (original)<br>
+++ cfe/trunk/lib/Serialization/<wbr>ASTReaderDecl.cpp Sat Aug  6 07:45:16 2016<br>
@@ -170,12 +170,12 @@ namespace clang {<br>
       ASTReader &Reader;<br>
       NamedDecl *New;<br>
       NamedDecl *Existing;<br>
-      mutable bool AddResult;<br>
+      bool AddResult;<br>
<br>
       unsigned AnonymousDeclNumber;<br>
       IdentifierInfo *TypedefNameForLinkage;<br>
<br>
-      void operator=(FindExistingResult&) = delete;<br>
+      void operator=(FindExistingResult &&) = delete;<br>
<br>
     public:<br>
       FindExistingResult(ASTReader &Reader)<br>
@@ -189,7 +189,7 @@ namespace clang {<br>
             AnonymousDeclNumber(<wbr>AnonymousDeclNumber),<br>
             TypedefNameForLinkage(<wbr>TypedefNameForLinkage) {}<br>
<br>
-      FindExistingResult(const FindExistingResult &Other)<br>
+      FindExistingResult(<wbr>FindExistingResult &&Other)<br>
           : Reader(Other.Reader), New(Other.New), Existing(Other.Existing),<br>
             AddResult(Other.AddResult),<br>
             AnonymousDeclNumber(Other.<wbr>AnonymousDeclNumber),<br>
<br></blockquote><div>Shouldn't these lines have std::move() everywhere to make them real move ctors?</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>