<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 26, 2016 at 4:37 PM Laxman Sole via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">laxmansole created this revision.<br>
laxmansole added reviewers: mclow.lists, howard.hinnant.<br>
laxmansole added subscribers: cfe-commits, sebpop, hiraditya, evandro, flyingforyou.<br>
<br>
<br>
Currently basic_string's destructor is not getting inlined. So adding 'inline' attribute to ~basic_string().<br></blockquote><div><br></div><div>'inline' just gives the compiler a little extra push to try to inline - it shouldn't really be needed (the compiler's heuristics should make the right choices). Have you looked to see if there's a bug in the optimizer that should be fixed instead?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Worked in collaboration with Aditya Kumar.<br>
<br>
<a href="https://reviews.llvm.org/D22834" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22834</a><br>
<br>
Files:<br>
  libcxx/include/string<br>
<br>
Index: libcxx/include/string<br>
===================================================================<br>
--- libcxx/include/string<br>
+++ libcxx/include/string<br>
@@ -2350,6 +2350,7 @@<br>
 #endif  // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS<br>
<br>
 template <class _CharT, class _Traits, class _Allocator><br>
+inline _LIBCPP_INLINE_VISIBILITY<br>
 basic_string<_CharT, _Traits, _Allocator>::~basic_string()<br>
 {<br>
 #if _LIBCPP_DEBUG_LEVEL >= 2<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>