<div dir="ltr">Ping</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 25, 2016 at 10:24 AM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ping?</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 18, 2016 at 11:28 AM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">What build problem did this cause? Did this just not compile (it looks as if ArgList has hasArg and hasFlag, so I'm not sure what the specific problem might've been)</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 13, 2016 at 11:45 PM Dean Michael Berris via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dberris<br>
Date: Thu Jul 14 01:37:46 2016<br>
New Revision: 275377<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=275377&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=275377&view=rev</a><br>
Log:<br>
Use hasFlag instead of hasArg<br>
<br>
Summary: Fix the build to use hasFlag instead of hasArg for checking some flags.<br>
<br>
Reviewers: echristo<br>
<br>
Subscribers: mehdi_amini, cfe-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D22338" rel="noreferrer" target="_blank">http://reviews.llvm.org/D22338</a><br>
<br>
Modified:<br>
    cfe/trunk/lib/Driver/Tools.cpp<br>
<br>
Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=275377&r1=275376&r2=275377&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=275377&r1=275376&r2=275377&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
+++ cfe/trunk/lib/Driver/Tools.cpp Thu Jul 14 01:37:46 2016<br>
@@ -4609,8 +4609,8 @@ void Clang::ConstructJob(Compilation &C,<br>
<br>
   Args.AddAllArgs(CmdArgs, options::OPT_finstrument_functions);<br>
<br>
-  if (Args.hasArg(options::OPT_fxray_instrument,<br>
-                  options::OPT_fnoxray_instrument, false)) {<br>
+  if (Args.hasFlag(options::OPT_fxray_instrument,<br>
+                   options::OPT_fnoxray_instrument, false)) {<br>
     CmdArgs.push_back("-fxray-instrument");<br>
     if (Arg *A = Args.getLastArg(options::OPT_fxray_instruction_threshold_,<br>
                                  options::OPT_fxray_instruction_threshold_EQ)) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></blockquote></div></blockquote></div>