I hear that he is on vacation.<br><br>On Wednesday, July 27, 2016, Hans Wennborg via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Richard: ping?<br>
<br>
On Fri, Jul 22, 2016 at 7:00 AM, Hans Wennborg <<a href="javascript:;" onclick="_e(event, 'cvml', 'hans@chromium.org')">hans@chromium.org</a>> wrote:<br>
> Richard: should we merge this to 3.9?<br>
><br>
> On Thu, Jul 21, 2016 at 6:31 PM, Erik Pilkington via cfe-commits<br>
> <<a href="javascript:;" onclick="_e(event, 'cvml', 'cfe-commits@lists.llvm.org')">cfe-commits@lists.llvm.org</a>> wrote:<br>
>> Author: epilk<br>
>> Date: Thu Jul 21 17:31:40 2016<br>
>> New Revision: 276350<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276350&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=276350&view=rev</a><br>
>> Log:<br>
>> [CodeGen] Fix a crash when constant folding switch statement<br>
>><br>
>> Differential revision: <a href="https://reviews.llvm.org/D22542" target="_blank">https://reviews.llvm.org/D22542</a><br>
>><br>
>> Modified:<br>
>>     cfe/trunk/lib/CodeGen/CGStmt.cpp<br>
>>     cfe/trunk/test/CodeGenCXX/switch-case-folding-2.cpp<br>
>><br>
>> Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGStmt.cpp?rev=276350&r1=276349&r2=276350&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGStmt.cpp?rev=276350&r1=276349&r2=276350&view=diff</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/lib/CodeGen/CGStmt.cpp (original)<br>
>> +++ cfe/trunk/lib/CodeGen/CGStmt.cpp Thu Jul 21 17:31:40 2016<br>
>> @@ -1264,6 +1264,14 @@ void CodeGenFunction::EmitCaseStmt(const<br>
>>  }<br>
>><br>
>>  void CodeGenFunction::EmitDefaultStmt(const DefaultStmt &S) {<br>
>> +  // If there is no enclosing switch instance that we're aware of, then this<br>
>> +  // default statement can be elided. This situation only happens when we've<br>
>> +  // constant-folded the switch.<br>
>> +  if (!SwitchInsn) {<br>
>> +    EmitStmt(S.getSubStmt());<br>
>> +    return;<br>
>> +  }<br>
>> +<br>
>>    llvm::BasicBlock *DefaultBlock = SwitchInsn->getDefaultDest();<br>
>>    assert(DefaultBlock->empty() &&<br>
>>           "EmitDefaultStmt: Default block already defined?");<br>
>><br>
>> Modified: cfe/trunk/test/CodeGenCXX/switch-case-folding-2.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/switch-case-folding-2.cpp?rev=276350&r1=276349&r2=276350&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/switch-case-folding-2.cpp?rev=276350&r1=276349&r2=276350&view=diff</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/test/CodeGenCXX/switch-case-folding-2.cpp (original)<br>
>> +++ cfe/trunk/test/CodeGenCXX/switch-case-folding-2.cpp Thu Jul 21 17:31:40 2016<br>
>> @@ -18,4 +18,13 @@ int main(void) {<br>
>>   return test(5);<br>
>>  }<br>
>><br>
>> +void other_test() {<br>
>> +  switch(0) {<br>
>> +  case 0:<br>
>> +    do {<br>
>> +    default:;<br>
>> +    } while(0);<br>
>> +  }<br>
>> +}<br>
>> +<br>
>>  // CHECK: call i32 (i8*, ...) @_Z6printfPKcz<br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="javascript:;" onclick="_e(event, 'cvml', 'cfe-commits@lists.llvm.org')">cfe-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="javascript:;" onclick="_e(event, 'cvml', 'cfe-commits@lists.llvm.org')">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote>