<div dir="ltr">Looks like I missed the target triple. Should work now. <div><br></div><div>Thanks,</div><div><br></div><div>-Nirav</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 27, 2016 at 4:41 PM, Bruno Cardoso Lopes <span dir="ltr"><<a href="mailto:bruno.cardoso@gmail.com" target="_blank">bruno.cardoso@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Nirav,<br>
<br>
This test is failing on darwin:<br>
<a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574</a><br>
<br>
Can you take a look?<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, Jul 27, 2016 at 12:57 PM, Nirav Dave via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: niravd<br>
> Date: Wed Jul 27 14:57:40 2016<br>
> New Revision: 276907<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276907&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=276907&view=rev</a><br>
> Log:<br>
> Add flags to toggle preservation of assembly comments<br>
><br>
> Summary: Add -fpreserve-as-comments and -fno-preserve-as-comments.<br>
><br>
> Reviewers: echristo, rnk<br>
><br>
> Subscribers: mehdi_amini, llvm-commits<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D22883" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22883</a><br>
><br>
> Added:<br>
> cfe/trunk/test/CodeGen/preserve-as-comments.c<br>
> Modified:<br>
> cfe/trunk/include/clang/Driver/Options.td<br>
> cfe/trunk/include/clang/Frontend/CodeGenOptions.def<br>
> cfe/trunk/lib/CodeGen/BackendUtil.cpp<br>
> cfe/trunk/lib/Driver/Tools.cpp<br>
> cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/Driver/Options.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=276907&r1=276906&r2=276907&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=276907&r1=276906&r2=276907&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Driver/Options.td (original)<br>
> +++ cfe/trunk/include/clang/Driver/Options.td Wed Jul 27 14:57:40 2016<br>
> @@ -1089,6 +1089,9 @@ def fpie : Flag<["-"], "fpie">, Group<f_<br>
> def fno_pie : Flag<["-"], "fno-pie">, Group<f_Group>;<br>
> def fplugin_EQ : Joined<["-"], "fplugin=">, Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<dsopath>">,<br>
> HelpText<"Load the named plugin (dynamic shared object)">;<br>
> +def fpreserve_as_comments : Flag<["-"], "fpreserve-as-comments">, Group<f_Group>;<br>
> +def fno_preserve_as_comments : Flag<["-"], "fno-preserve-as-comments">, Group<f_Group>, Flags<[CC1Option]>,<br>
> + HelpText<"Do not preserve comments in inline assembly">;<br>
> def fprofile_arcs : Flag<["-"], "fprofile-arcs">, Group<f_Group>;<br>
> def fno_profile_arcs : Flag<["-"], "fno-profile-arcs">, Group<f_Group>;<br>
> def framework : Separate<["-"], "framework">, Flags<[LinkerInput]>;<br>
><br>
> Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.def<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Frontend/CodeGenOptions.def?rev=276907&r1=276906&r2=276907&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Frontend/CodeGenOptions.def?rev=276907&r1=276906&r2=276907&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Frontend/CodeGenOptions.def (original)<br>
> +++ cfe/trunk/include/clang/Frontend/CodeGenOptions.def Wed Jul 27 14:57:40 2016<br>
> @@ -32,6 +32,7 @@ CODEGENOPT(DisableIntegratedAS, 1, 0) //<br>
> CODEGENOPT(CompressDebugSections, 1, 0) ///< -Wa,-compress-debug-sections<br>
> CODEGENOPT(RelaxELFRelocations, 1, 0) ///< -Wa,--mrelax-relocations<br>
> CODEGENOPT(AsmVerbose , 1, 0) ///< -dA, -fverbose-asm.<br>
> +CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comments.<br>
> CODEGENOPT(AssumeSaneOperatorNew , 1, 1) ///< implicit __attribute__((malloc)) operator new<br>
> CODEGENOPT(Autolink , 1, 1) ///< -fno-autolink<br>
> CODEGENOPT(ObjCAutoRefCountExceptions , 1, 0) ///< Whether ARC should be EH-safe.<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/BackendUtil.cpp?rev=276907&r1=276906&r2=276907&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/BackendUtil.cpp?rev=276907&r1=276906&r2=276907&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/BackendUtil.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/BackendUtil.cpp Wed Jul 27 14:57:40 2016<br>
> @@ -604,6 +604,7 @@ void EmitAssemblyHelper::CreateTargetMac<br>
> CodeGenOpts.IncrementalLinkerCompatible;<br>
> Options.MCOptions.MCFatalWarnings = CodeGenOpts.FatalWarnings;<br>
> Options.MCOptions.AsmVerbose = CodeGenOpts.AsmVerbose;<br>
> + Options.MCOptions.PreserveAsmComments = CodeGenOpts.PreserveAsmComments;<br>
> Options.MCOptions.ABIName = TargetOpts.ABI;<br>
><br>
> TM.reset(TheTarget->createTargetMachine(Triple, TargetOpts.CPU, FeaturesStr,<br>
><br>
> Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=276907&r1=276906&r2=276907&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=276907&r1=276906&r2=276907&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
> +++ cfe/trunk/lib/Driver/Tools.cpp Wed Jul 27 14:57:40 2016<br>
> @@ -4193,6 +4193,10 @@ void Clang::ConstructJob(Compilation &C,<br>
> true))<br>
> CmdArgs.push_back("-fno-jump-tables");<br>
><br>
> + if (!Args.hasFlag(options::OPT_fpreserve_as_comments,<br>
> + options::OPT_fno_preserve_as_comments, true))<br>
> + CmdArgs.push_back("-fno-preserve-as-comments");<br>
> +<br>
> if (Arg *A = Args.getLastArg(options::OPT_mregparm_EQ)) {<br>
> CmdArgs.push_back("-mregparm");<br>
> CmdArgs.push_back(A->getValue());<br>
><br>
> Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=276907&r1=276906&r2=276907&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=276907&r1=276906&r2=276907&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Frontend/CompilerInvocation.cpp (original)<br>
> +++ cfe/trunk/lib/Frontend/CompilerInvocation.cpp Wed Jul 27 14:57:40 2016<br>
> @@ -544,6 +544,7 @@ static bool ParseCodeGenArgs(CodeGenOpti<br>
> Args.hasFlag(OPT_fcoverage_mapping, OPT_fno_coverage_mapping, false);<br>
> Opts.DumpCoverageMapping = Args.hasArg(OPT_dump_coverage_mapping);<br>
> Opts.AsmVerbose = Args.hasArg(OPT_masm_verbose);<br>
> + Opts.PreserveAsmComments = !Args.hasArg(OPT_fno_preserve_as_comments);<br>
> Opts.AssumeSaneOperatorNew = !Args.hasArg(OPT_fno_assume_sane_operator_new);<br>
> Opts.ObjCAutoRefCountExceptions = Args.hasArg(OPT_fobjc_arc_exceptions);<br>
> Opts.CXAAtExit = !Args.hasArg(OPT_fno_use_cxa_atexit);<br>
><br>
> Added: cfe/trunk/test/CodeGen/preserve-as-comments.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/preserve-as-comments.c?rev=276907&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/preserve-as-comments.c?rev=276907&view=auto</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/CodeGen/preserve-as-comments.c (added)<br>
> +++ cfe/trunk/test/CodeGen/preserve-as-comments.c Wed Jul 27 14:57:40 2016<br>
> @@ -0,0 +1,12 @@<br>
> +// RUN: %clang_cc1 -S -fno-preserve-as-comments %s -o - | FileCheck %s --check-prefix=NOASM --check-prefix=CHECK<br>
> +// RUN: %clang_cc1 -S %s -o - | FileCheck %s --check-prefix=ASM --check-prefix=CHECK<br>
> +<br>
> +// CHECK-LABEL: main<br>
> +// CHECK: #APP<br>
> +// ASM: #comment<br>
> +// NOASM-NOT: #comment<br>
> +// CHECK: #NO_APP<br>
> +int main() {<br>
> + __asm__("/*comment*/");<br>
> + return 0;<br>
> +}<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Bruno Cardoso Lopes<br>
<a href="http://www.brunocardoso.cc" rel="noreferrer" target="_blank">http://www.brunocardoso.cc</a><br>
</font></span></blockquote></div><br></div>