<p dir="ltr">Yes please :)</p>
<div class="gmail_extra"><br><div class="gmail_quote">On 25 Jul 2016 10:13 p.m., "Vassil Vassilev via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It could, it fixes a set of issues wrt to modules.<br>
On 25/07/16 22:39, Hans Wennborg wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Should this be merged to 3.9?<br>
<br>
On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: vvassilev<br>
Date: Fri Jul 22 16:08:24 2016<br>
New Revision: 276473<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276473&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=276473&view=rev</a><br>
Log:<br>
[modules] Teach the ASTWriter to ignore mutations coming from the ASTReader.<br>
<br>
Processing update records (and loading a module, in general) might trigger<br>
unexpected calls to the ASTWriter (being a mutation listener). Now we have a<br>
mechanism to suppress those calls to the ASTWriter but notify other possible<br>
mutation listeners.<br>
<br>
Fixes <a href="https://llvm.org/bugs/show_bug.cgi?id=28332" rel="noreferrer" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=28332</a><br>
<br>
Patch by Cristina Cristescu and me.<br>
<br>
Reviewed by Richard Smith (D21800).<br>
<br>
Added:<br>
     cfe/trunk/test/Modules/Inputs/PR28332/<br>
     cfe/trunk/test/Modules/Inputs/PR28332/TextualInclude.h<br>
     cfe/trunk/test/Modules/Inputs/PR28332/a.h<br>
     cfe/trunk/test/Modules/Inputs/PR28332/b.h<br>
     cfe/trunk/test/Modules/Inputs/PR28332/c.h<br>
     cfe/trunk/test/Modules/Inputs/PR28332/module.modulemap<br>
     cfe/trunk/test/Modules/pr28332.cpp<br>
Modified:<br>
     cfe/trunk/include/clang/Serialization/ASTReader.h<br>
     cfe/trunk/lib/Serialization/ASTReader.cpp<br>
     cfe/trunk/lib/Serialization/ASTReaderDecl.cpp<br>
     cfe/trunk/lib/Serialization/ASTWriter.cpp<br>
</blockquote></blockquote>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>