<div dir="ltr">Should we fix the diagnostic? Or is the code triggering it just esoteric enough to not be a good justification for changing the warning?</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 19, 2016 at 1:42 PM Richard Smith via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rsmith<br>
Date: Tue Jul 19 15:35:09 2016<br>
New Revision: 276022<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276022&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=276022&view=rev</a><br>
Log:<br>
Attempt to bring peace to -Werror buildbots.<br>
<br>
Modified:<br>
    libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp<br>
<br>
Modified: libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp?rev=276022&r1=276021&r2=276022&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp?rev=276022&r1=276021&r2=276022&view=diff</a><br>
==============================================================================<br>
--- libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp (original)<br>
+++ libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp Tue Jul 19 15:35:09 2016<br>
@@ -12,6 +12,12 @@<br>
 #include <cassert><br>
 #include <cstdlib><br>
<br>
+// Clang emits a warning on converting an object of type nullptr_t to bool,<br>
+// even in generic code. Suppress it.<br>
+#if defined(__clang__)<br>
+#pragma clang diagnostic ignored "-Wnull-conversion"<br>
+#endif<br>
+<br>
 struct A {};<br>
<br>
 template<typename T, bool CanCatchNullptr><br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>