<div dir="ltr">Thank you. </div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 14, 2016 at 4:00 PM Ben Langmuir <<a href="mailto:blangmuir@apple.com">blangmuir@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Thanks! it was actually my earlier commit that broke it, it just didn’t turn up until a second build happened.<div><br></div><div>Fixed in r275496</div></div><div style="word-wrap:break-word"><div><br><div><br></div><div><br><div><blockquote type="cite"><div>On Jul 14, 2016, at 2:55 PM, Vitaly Buka <<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>> wrote:</div><br class="m_-1172662215159357412Apple-interchange-newline"><div><div dir="ltr">The patch breaks this test: <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/14659/steps/check-clang%20msan/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/14659/steps/check-clang%20msan/logs/stdio</a></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 14, 2016 at 1:16 PM Ben Langmuir via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: benlangmuir<br>
Date: Thu Jul 14 15:08:43 2016<br>
New Revision: 275464<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=275464&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=275464&view=rev</a><br>
Log:<br>
Attempt to workaround Windows bots after my previous commit<br>
<br>
For some reason it seems the second invocation is getting DMOD_OTHER_H<br>
set to a path with/forward/slashes, but one of the use sites<br>
has\back\slashes. There should be no difference with what was already<br>
there, but for now try to avoid checking those paths.<br>
<br>
Modified:<br>
    cfe/trunk/test/Index/index-module.m<br>
<br>
Modified: cfe/trunk/test/Index/index-module.m<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/index-module.m?rev=275464&r1=275463&r2=275464&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/index-module.m?rev=275464&r1=275463&r2=275464&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Index/index-module.m (original)<br>
+++ cfe/trunk/test/Index/index-module.m Thu Jul 14 15:08:43 2016<br>
@@ -20,7 +20,7 @@ int glob;<br>
 // CHECK-NOT: [indexDeclaration]<br>
<br>
 // RUN: c-index-test -index-tu %t.cache/DependsOnModule.pcm | FileCheck %s -check-prefix=CHECK-DMOD<br>
-// RUN: c-index-test -index-tu %t.cache.sys/DependsOnModule.pcm | FileCheck %s -check-prefix=CHECK-DMOD<br>
+// RUN: c-index-test -index-tu %t.cache.sys/DependsOnModule.pcm | FileCheck %s -check-prefix=CHECK-DMOD-AST<br>
<br>
 // CHECK-DMOD:      [startedTranslationUnit]<br>
 // CHECK-DMOD-NEXT: [ppIncludedFile]: [[DMOD_MODULE_H:.*/Modules/Inputs/DependsOnModule\.framework[/\\]Headers[/\\]DependsOnModule\.h]] | {{.*}} | hash loc: <invalid> | {{.*}} | module: DependsOnModule<br>
@@ -31,7 +31,6 @@ int glob;<br>
 // CHECK-DMOD-NEXT: [ppIncludedFile]: [[DMOD_SUB_OTHER_H:.*/Modules/Inputs/DependsOnModule.framework[/\\]Frameworks/SubFramework\.framework/Headers/Other\.h]] | name: "SubFramework/Other.h" | hash loc: [[DMOD_SUB_H]]:1:1 | isImport: 0 | isAngled: 0 | isModule: 0 | module: DependsOnModule.SubFramework.Other<br>
 // CHECK-DMOD-NEXT: [ppIncludedFile]: [[DMOD_PRIVATE_H:.*/Modules/Inputs/DependsOnModule.framework[/\\]PrivateHeaders[/\\]DependsOnModulePrivate.h]] | {{.*}} | hash loc: <invalid> | {{.*}} | module: DependsOnModule.Private.DependsOnModule<br>
 // CHECK-DMOD-NEXT: [importedASTFile]: {{.*}}.cache{{(.sys)?[/\\]}}Module.pcm | loc: [[DMOD_MODULE_H]]:1:1 | name: "Module" | isImplicit: 1<br>
-//<br>
 // CHECK-DMOD-NEXT: [indexDeclaration]: kind: variable | name: depends_on_module_other | {{.*}} | loc: [[DMOD_OTHER_H]]:1:5<br>
 // CHECK-DMOD-NEXT: [indexDeclaration]: kind: variable | name: template | {{.*}} | loc: [[DMOD_NOT_CXX_H]]:1:12<br>
 // CHECK-DMOD-NEXT: [indexDeclaration]: kind: variable | name: sub_framework | {{.*}} | loc: [[DMOD_SUB_H]]:2:8<br>
@@ -39,6 +38,8 @@ int glob;<br>
 // CHECK-DMOD-NEXT: [indexDeclaration]: kind: variable | name: depends_on_module_private | {{.*}} | loc: [[DMOD_PRIVATE_H]]:1:5<br>
 // CHECK-DMOD-NOT: [indexDeclaration]<br>
<br>
+// CHECK-DMOD-AST: [importedASTFile]: {{.*}}.cache.sys{{[/\\]}}Module.pcm | loc: {{.*}}DependsOnModule.h:1:1 | name: "Module" | isImplicit: 1<br>
+<br>
 // RUN: c-index-test -index-tu %t.cache/Module.pcm | FileCheck %s -check-prefix=CHECK-TMOD<br>
<br>
 // CHECK-TMOD:      [startedTranslationUnit]<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</div></blockquote></div><br></div></div></div></blockquote></div>