<div dir="ltr">Thanks Mikael -- this has been fixed in r275377 (<a href="http://reviews.llvm.org/rL275377">http://reviews.llvm.org/rL275377</a>).<div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 14, 2016 at 7:30 PM Mikael Holmén <<a href="mailto:mikael.holmen@ericsson.com" target="_blank">mikael.holmen@ericsson.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
Your commit<br>
<br>
     Add C++ dependencies to xray runtime<br>
<br>
Doesn't compile with gcc. At least 5.3 and 4.8.4 complains about this<br>
change:<br>
<br>
+  if (Args.hasArg(options::OPT_fxray_instrument,<br>
+                  options::OPT_fnoxray_instrument, false)) {<br>
+    CmdArgs.push_back("-fxray-instrument");<br>
+    if (Arg *A = Args.getLastArg(options::OPT_fxray_instruction_threshold_,<br>
+<br>
options::OPT_fxray_instruction_threshold_EQ)) {<br>
+      CmdArgs.push_back("-fxray-instruction-threshold");<br>
+      CmdArgs.push_back(A->getValue());<br>
+    }<br>
+  }<br>
+<br>
<br>
../tools/clang/lib/Driver/Tools.cpp:4613:57: error: converting to<br>
'llvm::opt::OptSpecifier' from initializer list would use explicit<br>
constructor 'llvm::opt::OptSpecifier::OptSpecifier(bool)'<br>
                    options::OPT_fnoxray_instrument, false)) {<br>
                                                          ^<br>
In file included from ../include/llvm/Option/OptTable.h:15:0,<br>
                  from ../include/llvm/Option/Option.h:15,<br>
                  from ../tools/clang/lib/Driver/Tools.h:19,<br>
                  from ../tools/clang/lib/Driver/Tools.cpp:10:<br>
../include/llvm/Option/OptSpecifier.h:24:14: error:<br>
'llvm::opt::OptSpecifier::OptSpecifier(bool)' is private<br>
      explicit OptSpecifier(bool) = delete;<br>
               ^<br>
../tools/clang/lib/Driver/Tools.cpp:4613:57: error: within this context<br>
                    options::OPT_fnoxray_instrument, false)) {<br>
                                                          ^<br>
../tools/clang/lib/Driver/Tools.cpp:4613:57: error: use of deleted<br>
function 'llvm::opt::OptSpecifier::OptSpecifier(bool)'<br>
In file included from ../include/llvm/Option/OptTable.h:15:0,<br>
                  from ../include/llvm/Option/Option.h:15,<br>
                  from ../tools/clang/lib/Driver/Tools.h:19,<br>
                  from ../tools/clang/lib/Driver/Tools.cpp:10:<br>
../include/llvm/Option/OptSpecifier.h:24:14: error: declared here<br>
      explicit OptSpecifier(bool) = delete;<br>
               ^<br>
In file included from<br>
../tools/clang/include/clang/Driver/SanitizerArgs.h:15:0,<br>
                  from ../tools/clang/lib/Driver/Tools.cpp:24:<br>
../include/llvm/Option/ArgList.h:191:8: error:   initializing argument 3<br>
of 'bool llvm::opt::ArgList::hasArg(llvm::opt::OptSpecifier,<br>
llvm::opt::OptSpecifier, llvm::opt::OptSpecifier) const'<br>
    bool hasArg(OptSpecifier Id0, OptSpecifier Id1, OptSpecifier Id2)<br>
const {<br>
         ^<br>
ninja: build stopped: subcommand failed.<br>
system(/proj/flexasic/app/ninja/1.4/SLED11-64/bin/ninja -j1 -C<br>
build-all-gcc53 llc llvm-stress opt clang all) failed: child exited with<br>
value 1<br>
</blockquote></div></div></div>