<div dir="ltr">The test cfe/trunk/test/Frontend/<a href="http://opencl.cl">opencl.cl</a> that was added here appears to fail.<div><br></div><div>Running "ninja check-clang" doesn't pick this up because cfe/trunk/test/Frontend/lit.local.cfg doesn't contain '.cl' as a file suffix:</div><div><br></div><div>config.suffixes = ['.c', '.cpp', '.m', '.mm', '.ll']<br></div><div><br></div><div>As soon as I add the suffix:</div><div><br></div><div>config.suffixes = ['.c', '.cpp', '.m', '.mm', '.ll', '.cl']<br></div><div><br></div><div>the test fails. The failure seems to happen because of the new "CHECK_INVALID_OPENCL_VERSION" checks. For OpenCL versions 1.1 and 1.2, compilation fails for these checks because of the expected error "blocks support disabled".</div><div><br></div><div>A solution seems to be to add "-fblocks" to the command line for these two checks.</div><div><br></div><div>I'll be sending a patch with this fix out for review shortly.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 13 July 2016 at 23:28, Yaxun Liu via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL275318: [OpenCL] Fixes failures in test/Driver/<a href="http://opencl.cl" rel="noreferrer" target="_blank">opencl.cl</a>. (authored by yaxunl).<br>
<br>
Changed prior to commit:<br>
<a href="http://reviews.llvm.org/D22170?vs=63722&id=63862#toc" rel="noreferrer" target="_blank">http://reviews.llvm.org/D22170?vs=63722&id=63862#toc</a><br>
<span class=""><br>
Repository:<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D22170" rel="noreferrer" target="_blank">http://reviews.llvm.org/D22170</a><br>
<br>
Files:<br>
</span> cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
cfe/trunk/test/Driver/<a href="http://opencl.cl" rel="noreferrer" target="_blank">opencl.cl</a><br>
cfe/trunk/test/Frontend/<a href="http://opencl-blocks.cl" rel="noreferrer" target="_blank">opencl-blocks.cl</a><br>
cfe/trunk/test/Frontend/<a href="http://opencl.cl" rel="noreferrer" target="_blank">opencl.cl</a><br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:16px;font-family:Arial;color:rgb(0,0,0);font-weight:700;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Martin Böhme</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:13.3333333333333px;font-family:Arial;color:rgb(102,102,102);vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Software Engineer</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:13.3333333333333px;font-family:Arial;color:rgb(102,102,102);vertical-align:baseline;white-space:pre-wrap;background-color:transparent"><a href="mailto:mboehme@google.com" target="_blank">mboehme@google.com</a></span><span style="font-size:13.3333333333333px;font-family:Arial;color:rgb(102,102,102);vertical-align:baseline;white-space:pre-wrap;background-color:transparent"><br></span><span style="font-size:13.3333333333333px;font-family:Arial;color:rgb(102,102,102);vertical-align:baseline;white-space:pre-wrap;background-color:transparent">+49 176 64059273</span></p><span style="font-size:13.3333333333333px;font-family:Arial;color:rgb(102,102,102);vertical-align:baseline;white-space:pre-wrap;background-color:transparent"><img src="https://lh3.googleusercontent.com/jArLagMFiBykGEq2mtMjIS9RO3ydtGbI1KRMmdY7daBuMP4HQbM7p92vdv8yolHBV9sE4YXu7ORFjsy6mcF6LGJOjQhqkd4PrG43u1U2toF3BQIitx8YMjbU9hqX9u3U8MU=s1600" width="100px;" height="58px;" style="border:none"></span></span><br><div><div style="font-size:13px"><span style="font-family:Arial,Verdana,sans-serif"><font color="#666666">Google Germany GmbH</font></span></div><div><div style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font color="#666666">Maria-Goeppert-Str. 3</font></div><div style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font color="#666666">23562 Lübeck<br></font></div><div style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font color="#666666"><br></font></div><div style="font-family:Arial,Verdana,sans-serif"><span><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10.6666666666667px;font-family:Arial;color:rgb(183,183,183);vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10.6666666666667px;font-family:Arial;color:rgb(183,183,183);vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Registergericht und -nummer: Hamburg, HRB 86891</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10.6666666666667px;font-family:Arial;color:rgb(183,183,183);vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Sitz der Gesellschaft: Hamburg</span></p><br><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10.6666666666667px;font-family:Arial;color:rgb(183,183,183);vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank.</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10.6666666666667px;font-family:Arial;color:rgb(183,183,183);vertical-align:baseline;white-space:pre-wrap;background-color:transparent"> </span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10.6666666666667px;font-family:Arial;color:rgb(183,183,183);vertical-align:baseline;white-space:pre-wrap;background-color:transparent">This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.</span></p></span></div></div></div></div></div></div></div></div></div>
</div>