<div dir="ltr">Btw we do have some advice for these situations in the programmer's manual: <a href="http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations">http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations</a><div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 7, 2016 at 4:24 AM, Simon Pilgrim via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rksimon<br>
Date: Thu Jul  7 06:24:38 2016<br>
New Revision: 274748<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=274748&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=274748&view=rev</a><br>
Log:<br>
Fix "not all control paths return a value" warning on MSVC<br>
<br>
This time without causing a 'all enums handled' warning on other compilers.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Basic/Targets.cpp<br>
<br>
Modified: cfe/trunk/lib/Basic/Targets.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=274748&r1=274747&r2=274748&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=274748&r1=274747&r2=274748&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Basic/Targets.cpp (original)<br>
+++ cfe/trunk/lib/Basic/Targets.cpp Thu Jul  7 06:24:38 2016<br>
@@ -1777,7 +1777,7 @@ public:<br>
       // Set __CUDA_ARCH__ for the GPU specified.<br>
       std::string CUDAArchCode = [this] {<br>
         switch (GPU) {<br>
-        case CudaArch::UNKNOWN:<br>
+        default:<br>
           assert(false && "No GPU arch when compiling CUDA device code.");<br>
           return "";<br>
         case CudaArch::SM_20:<br>
@@ -1804,8 +1804,6 @@ public:<br>
           return "610";<br>
         case CudaArch::SM_62:<br>
           return "620";<br>
-         default:<br>
-           llvm_unreachable("unhandled CudaArch");<br>
         }<br>
       }();<br>
       Builder.defineMacro("__CUDA_ARCH__", CUDAArchCode);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>