<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Okay, that is peculiar. But I can repro it. If I put either orbis-ld or orbis-ld.exe co-located with clang.exe, it builds a command
line without the .exe suffix (but using the directory where clang.exe lives).<o:p></o:p></span></a></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I do think a bug report would have been appropriate, rather than just munging the test…
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">As it is (with your mods) the test is not checking what we want it to check. I'll write an internal bug for this.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Sean Silva [mailto:chisophugis@gmail.com]
<br>
<b>Sent:</b> Thursday, June 30, 2016 4:03 PM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> cfe-commits (cfe-commits@lists.llvm.org)<br>
<b>Subject:</b> Re: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Thu, Jun 30, 2016 at 3:52 PM, Robinson, Paul <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal"><br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org">cfe-commits-bounces@lists.llvm.org</a>] On Behalf Of<br>
> Sean Silva via cfe-commits<br>
> Sent: Tuesday, June 28, 2016 5:29 PM<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> Subject: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"<br>
><br>
> Author: silvas<br>
> Date: Tue Jun 28 19:29:23 2016<br>
> New Revision: 274084<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=274084&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=274084&view=rev</a><br>
> Log:<br>
> Revert "[PS4] Tighten up a test (noticed in passing)"<br>
><br>
> This reverts commit r269709.<br>
><br>
> r262285 changed this deliberately so that the test would not be<br>
> sensitive to which binaries are in the same directory as clang.<br>
> See the commit message of that commit for more background.<br>
<br>
Okay, but the point of the test is to match a "file.exe" instead<br>
of just "file". See commentary at the top of the test.<br>
Also "orbis-ld" is a prefix of "orbis-ld.gold" and so matching<br>
just the former doesn't verify we're looking for the right one.<br>
<br>
I understand taking out the path part of the check in r262285 but<br>
if you named your test linker "orbis-ld.exe" instead of "orbis-ld"<br>
then the test would pass with r269709, right?<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Unfortunately not.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-- Sean Silva<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"> If that's all this<br>
is about, please undo this revert and use the standard Windows<br>
file extension for your test linkers.<br>
--paulr<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
><br>
> Modified:<br>
> cfe/trunk/test/Driver/ps4-linker-win.c<br>
><br>
> Modified: cfe/trunk/test/Driver/ps4-linker-win.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/ps4-linker-" target="_blank">
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/ps4-linker-</a><br>
> win.c?rev=274084&r1=274083&r2=274084&view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- cfe/trunk/test/Driver/ps4-linker-win.c (original)<br>
> +++ cfe/trunk/test/Driver/ps4-linker-win.c Tue Jun 28 19:29:23 2016<br>
> @@ -22,5 +22,5 @@<br>
> // RUN: env "PATH=%T;%PATH%;" %clang -target x86_64-scei-ps4 %s -shared<br>
> \<br>
> // RUN: -fuse-ld=ps4 -### 2>&1 | FileCheck --check-prefix=CHECK-PS4-<br>
> LINKER %s<br>
><br>
> -// CHECK-PS4-GOLD: <a href="file:///\\orbis-ld.gold.exe">\\orbis-ld.gold.exe</a>"<br>
> -// CHECK-PS4-LINKER: <a href="file:///\\orbis-ld.exe">\\orbis-ld.exe</a>"<br>
> +// CHECK-PS4-GOLD: <a href="file:///\\orbis-ld.gold">\\orbis-ld.gold</a><br>
> +// CHECK-PS4-LINKER: <a href="file:///\\orbis-ld">\\orbis-ld</a><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>