<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 30, 2016 at 5:30 PM, Robinson, Paul <span dir="ltr"><<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><a name="m_-6325035471274442508__MailEndCompose"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Okay, that is peculiar. But I can repro it. If I put either orbis-ld or orbis-ld.exe co-located with clang.exe, it builds a command
line without the .exe suffix (but using the directory where clang.exe lives).</span></a></p></div></div></blockquote><div><br></div><div>Yeah, as I described in the commit message of r262285 it is due to an extra-high-priority lookup done in <span style="font-size:12.8px">Driver::GetProgramPath that overrides the PATH lookup. </span><span style="font-size:12.8px">In fact, in the production PS4 SDK the PATH lookup purportedly tested in this test *never occurs* since these "look in the the directory containing clang" lookups always find orbis-ld first (since it is always(?) right beside clang).</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">So this test probably needs to be changed to copy the clang binary into a directory, put an orbis-ld.exe there, and then verify that clang finds that orbis-ld. There is little point to testing PATH lookups since AFAIK we don't really advertise to licensees that they should mess with the contents of the sdk dir (i.e. to cause clang to not be beside orbis-ld and instead find orbis-ld through a PATH lookup).</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">(actually, copying the clang binary is not ideal since that binary may be quite large)</span></div><div><span style="font-size:12.8px"><br></span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><a name="m_-6325035471274442508__MailEndCompose"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></a></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">I do think a bug report would have been appropriate, rather than just munging the test… </span></p></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">As it is (with your mods) the test is not checking what we want it to check. I'll write an internal bug for this.</span></p></div></div></blockquote><div><br></div><div>Thanks. To be completely honest I had not noticed that due to the prefix property it wouldn't quite check the right thing.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div style="border-style:none none none solid;border-left-width:1.5pt;border-left-color:blue;padding:0in 0in 0in 4pt">
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span style="font-size:10pt;font-family:Tahoma,sans-serif"> Sean Silva [mailto:<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>]
<br>
<b>Sent:</b> Thursday, June 30, 2016 4:03 PM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> cfe-commits (<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>)<br>
<b>Subject:</b> Re: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Thu, Jun 30, 2016 at 3:52 PM, Robinson, Paul <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal"><br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org" target="_blank">cfe-commits-bounces@lists.llvm.org</a>] On Behalf Of<br>
> Sean Silva via cfe-commits<br>
> Sent: Tuesday, June 28, 2016 5:29 PM<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> Subject: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"<br>
><br>
> Author: silvas<br>
> Date: Tue Jun 28 19:29:23 2016<br>
> New Revision: 274084<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=274084&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=274084&view=rev</a><br>
> Log:<br>
> Revert "[PS4] Tighten up a test (noticed in passing)"<br>
><br>
> This reverts commit r269709.<br>
><br>
> r262285 changed this deliberately so that the test would not be<br>
> sensitive to which binaries are in the same directory as clang.<br>
> See the commit message of that commit for more background.<br>
<br>
Okay, but the point of the test is to match a "file.exe" instead<br>
of just "file". See commentary at the top of the test.<br>
Also "orbis-ld" is a prefix of "orbis-ld.gold" and so matching<br>
just the former doesn't verify we're looking for the right one.<br>
<br>
I understand taking out the path part of the check in r262285 but<br>
if you named your test linker "orbis-ld.exe" instead of "orbis-ld"<br>
then the test would pass with r269709, right?<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Unfortunately not.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">-- Sean Silva<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-style:none none none solid;border-left-width:1pt;border-left-color:rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"> If that's all this<br>
is about, please undo this revert and use the standard Windows<br>
file extension for your test linkers.<br>
--paulr<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><br>
><br>
> Modified:<br>
> cfe/trunk/test/Driver/ps4-linker-win.c<br>
><br>
> Modified: cfe/trunk/test/Driver/ps4-linker-win.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/ps4-linker-" target="_blank">
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/ps4-linker-</a><br>
> win.c?rev=274084&r1=274083&r2=274084&view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- cfe/trunk/test/Driver/ps4-linker-win.c (original)<br>
> +++ cfe/trunk/test/Driver/ps4-linker-win.c Tue Jun 28 19:29:23 2016<br>
> @@ -22,5 +22,5 @@<br>
> // RUN: env "PATH=%T;%PATH%;" %clang -target x86_64-scei-ps4 %s -shared<br>
> \<br>
> // RUN: -fuse-ld=ps4 -### 2>&1 | FileCheck --check-prefix=CHECK-PS4-<br>
> LINKER %s<br>
><br>
> -// CHECK-PS4-GOLD: <a>\\orbis-ld.gold.exe</a>"<br>
> -// CHECK-PS4-LINKER: <a>\\orbis-ld.exe</a>"<br>
> +// CHECK-PS4-GOLD: <a>\\orbis-ld.gold</a><br>
> +// CHECK-PS4-LINKER: <a>\\orbis-ld</a><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><u></u><u></u></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div></div>