<p dir="ltr">LGTM</p>
<div class="gmail_extra"><br><div class="gmail_quote">On 16 Jun 2016 3:07 p.m., "Pirama Arumuga Nainar via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">pirama created this revision.<br>
pirama added a reviewer: rsmith.<br>
pirama added subscribers: srhines, cfe-commits.<br>
<br>
If the RenderScript LangOpt is set, either via '-x renderscript' or the '.rs'<br>
file extension, set the DWARF language tag to be that of RenderScript.<br>
<br>
<a href="http://reviews.llvm.org/D21451" rel="noreferrer" target="_blank">http://reviews.llvm.org/D21451</a><br>
<br>
Files:<br>
lib/CodeGen/CGDebugInfo.cpp<br>
test/CodeGen/<a href="http://debug-info-renderscript-tag.rs" rel="noreferrer" target="_blank">debug-info-renderscript-tag.rs</a><br>
<br>
Index: test/CodeGen/<a href="http://debug-info-renderscript-tag.rs" rel="noreferrer" target="_blank">debug-info-renderscript-tag.rs</a><br>
===================================================================<br>
--- /dev/null<br>
+++ test/CodeGen/<a href="http://debug-info-renderscript-tag.rs" rel="noreferrer" target="_blank">debug-info-renderscript-tag.rs</a><br>
@@ -0,0 +1,3 @@<br>
+// RUN: %clang -emit-llvm -S -g %s -o - | FileCheck %s<br>
+<br>
+// CHECK: !DICompileUnit(language: DW_LANG_GOOGLE_RenderScript{{.*}})<br>
Index: lib/CodeGen/CGDebugInfo.cpp<br>
===================================================================<br>
--- lib/CodeGen/CGDebugInfo.cpp<br>
+++ lib/CodeGen/CGDebugInfo.cpp<br>
@@ -383,6 +383,8 @@<br>
LangTag = llvm::dwarf::DW_LANG_C_plus_plus;<br>
} else if (LO.ObjC1) {<br>
LangTag = llvm::dwarf::DW_LANG_ObjC;<br>
+ } else if (LO.RenderScript) {<br>
+ LangTag = llvm::dwarf::DW_LANG_GOOGLE_RenderScript;<br>
} else if (LO.C99) {<br>
LangTag = llvm::dwarf::DW_LANG_C99;<br>
} else {<br>
<br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div></div>