<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks the suggestion, David. I did not realize __attribute__ is supported by Windows targets.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Zvi<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> David Majnemer [mailto:david.majnemer@gmail.com]
<br>
<b>Sent:</b> Thursday, June 09, 2016 17:48<br>
<b>To:</b> reviews+D21173+public+9a6e31402e430422@reviews.llvm.org; Rackover, Zvi <zvi.rackover@intel.com><br>
<b>Cc:</b> Aboud, Amjad <amjad.aboud@intel.com>; mkuper@google.com; echristo@gmail.com; cfe-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><br>
<br>
On Thursday, June 9, 2016, Zvi Rackover via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">zvi created this revision.<br>
zvi added reviewers: aaboud, mkuper, echristo, cfe-commits.<br>
zvi set the repository for this revision to rL LLVM.<br>
zvi added a project: clang-c.<br>
Herald added a subscriber: mehdi_amini.<br>
<br>
This patch adds support for the _MM_ALIGN16 attribute on non-windows targets. This aligns Clang with ICC which supports the attribute on all targets.<br>
<br>
Fixes PR28056<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D21173" target="_blank">http://reviews.llvm.org/D21173</a><br>
<br>
Files:<br>
lib/Headers/xmmintrin.h<br>
test/Headers/xmmintrin.c<br>
<br>
Index: test/Headers/xmmintrin.c<br>
===================================================================<br>
--- test/Headers/xmmintrin.c<br>
+++ test/Headers/xmmintrin.c<br>
@@ -7,6 +7,9 @@<br>
// REQUIRES: x86-registered-target<br>
#include <xmmintrin.h><br>
<br>
+// CHECK: @c = common global i8 0, align 16<br>
+_MM_ALIGN16 char c;<br>
+<br>
// Make sure the last step of _mm_cvtps_pi16 converts <4 x i32> to <4 x i16> by<br>
// checking that clang emits PACKSSDW instead of PACKSSWB.<br>
<br>
Index: lib/Headers/xmmintrin.h<br>
===================================================================<br>
--- lib/Headers/xmmintrin.h<br>
+++ lib/Headers/xmmintrin.h<br>
@@ -2823,6 +2823,8 @@<br>
<br>
#ifdef _MSC_VER<br>
#define _MM_ALIGN16 __declspec(align(16))<br>
+#else<br>
+#define _MM_ALIGN16 __attribute__((aligned(16)))<br>
#endif<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I would just use the __attribute__ spelling, no need for two definitions<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
#define _MM_SHUFFLE(z, y, x, w) (((z) << 6) | ((y) << 4) | ((x) << 2) | (w))<br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
<p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>