<div dir="ltr">Can you add this to the release notes? It'll for example break chromium's crash server (we can fix this on our end by explicitly passing -Wl,--build-id for release builds, but we only saw this commit fly by by chance.)</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 3, 2016 at 1:26 PM, Rafael Espindola via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Fri Jun  3 12:26:16 2016<br>
New Revision: 271692<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=271692&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=271692&view=rev</a><br>
Log:<br>
Don't pass --build-id to ld by default.<br>
<br>
We now have a cmake option to change the default: ENABLE_LINKER_BUILD_ID.<br>
<br>
The reason is that build-id is fairly expensive, so we shouldn't impose<br>
it in the regular edit/build cycle.<br>
<br>
This is similar to gcc, that has an off by default --enable-linker-build-id<br>
option.<br>
<br>
Modified:<br>
    cfe/trunk/CMakeLists.txt<br>
    cfe/trunk/include/clang/Config/config.h.cmake<br>
    cfe/trunk/lib/Driver/ToolChains.cpp<br>
<br>
Modified: cfe/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=271692&r1=271691&r2=271692&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=271692&r1=271691&r2=271692&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/CMakeLists.txt (original)<br>
+++ cfe/trunk/CMakeLists.txt Fri Jun  3 12:26:16 2016<br>
@@ -197,6 +197,8 @@ set(GCC_INSTALL_PREFIX "" CACHE PATH "Di<br>
 set(DEFAULT_SYSROOT "" CACHE PATH<br>
   "Default <path> to all compiler invocations for --sysroot=<path>." )<br>
<br>
+set(ENABLE_LINKER_BUILD_ID OFF CACHE BOOL "pass --build-id to ld")<br>
+<br>
 set(CLANG_DEFAULT_CXX_STDLIB "" CACHE STRING<br>
   "Default C++ stdlib to use (empty for architecture default, \"libstdc++\" or \"libc++\"")<br>
 if (NOT(CLANG_DEFAULT_CXX_STDLIB STREQUAL "" OR<br>
<br>
Modified: cfe/trunk/include/clang/Config/config.h.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Config/config.h.cmake?rev=271692&r1=271691&r2=271692&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Config/config.h.cmake?rev=271692&r1=271691&r2=271692&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Config/config.h.cmake (original)<br>
+++ cfe/trunk/include/clang/Config/config.h.cmake Fri Jun  3 12:26:16 2016<br>
@@ -38,4 +38,7 @@<br>
 /* Linker version detected at compile time. */<br>
 #cmakedefine HOST_LINK_VERSION "${HOST_LINK_VERSION}"<br>
<br>
+/* pass --build-id to ld */<br>
+#cmakedefine ENABLE_LINKER_BUILD_ID<br>
+<br>
 #endif<br>
<br>
Modified: cfe/trunk/lib/Driver/ToolChains.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=271692&r1=271691&r2=271692&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=271692&r1=271691&r2=271692&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Driver/ToolChains.cpp (original)<br>
+++ cfe/trunk/lib/Driver/ToolChains.cpp Fri Jun  3 12:26:16 2016<br>
@@ -3978,10 +3978,9 @@ Linux::Linux(const Driver &D, const llvm<br>
   if (IsRedhat(Distro) && Distro != RHEL5 && Distro != RHEL6)<br>
     ExtraOpts.push_back("--no-add-needed");<br>
<br>
-  if ((IsDebian(Distro) && Distro >= DebianSqueeze) || IsOpenSUSE(Distro) ||<br>
-      (IsRedhat(Distro) && Distro != RHEL5) ||<br>
-      (IsUbuntu(Distro) && Distro >= UbuntuKarmic))<br>
-    ExtraOpts.push_back("--build-id");<br>
+#ifdef ENABLE_LINKER_BUILD_ID<br>
+  ExtraOpts.push_back("--build-id");<br>
+#endif<br>
<br>
   if (IsOpenSUSE(Distro))<br>
     ExtraOpts.push_back("--enable-new-dtags");<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>