<div dir="ltr">@Compnerd, Sorry I had to do a partial revert to get the build going again.<div><br></div><div>I'll look into this more this week and I'll send you instructions to reproduce tomorrow.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 2, 2016 at 2:14 AM, Eric Fiselier via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Thu Jun  2 03:14:28 2016<br>
New Revision: 271500<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=271500&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=271500&view=rev</a><br>
Log:<br>
Partially revert r270816: build with -fvisibility=hidden.<br>
<br>
This patch breaks the ABI on linux when libc++abi.a is statically linked into<br>
libc++.so. Certain libc++ symbols get exported from libc++abi.a as hidden<br>
and therefore they also get hidden in libc++.so.<br>
<br>
The symbols is question are:<br>
<br>
* _ZNKSt3__121__basic_string_commonILb1EE20__throw_out_of_rangeEv<br>
* _ZNKSt3__121__basic_string_commonILb1EE20__throw_length_errorEv<br>
* _ZNKSt3__120__vector_base_commonILb1EE20__throw_length_errorEv<br>
<br>
I imagine we just need to fix the visibility for these symbols in the libc++<br>
headers but I'm reverting the patch until it's sorted.<br>
<br>
Modified:<br>
    libcxxabi/trunk/CMakeLists.txt<br>
    libcxxabi/trunk/cmake/config-ix.cmake<br>
<br>
Modified: libcxxabi/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/CMakeLists.txt?rev=271500&r1=271499&r2=271500&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/CMakeLists.txt?rev=271500&r1=271499&r2=271500&view=diff</a><br>
==============================================================================<br>
--- libcxxabi/trunk/CMakeLists.txt (original)<br>
+++ libcxxabi/trunk/CMakeLists.txt Thu Jun  2 03:14:28 2016<br>
@@ -293,8 +293,6 @@ else()<br>
   append_if(LIBCXXABI_CXX_FLAGS LIBCXXABI_HAS_NO_EHA_FLAG -EHa-)<br>
 endif()<br>
<br>
-append_if(LIBCXXABI_COMPILE_FLAGS LIBCXXABI_HAS_FVISIBILITY_HIDDEN_FLAG -fvisibility=hidden)<br>
-<br>
 # Assert<br>
 string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)<br>
 if (LIBCXXABI_ENABLE_ASSERTIONS)<br>
<br>
Modified: libcxxabi/trunk/cmake/config-ix.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/cmake/config-ix.cmake?rev=271500&r1=271499&r2=271500&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/cmake/config-ix.cmake?rev=271500&r1=271499&r2=271500&view=diff</a><br>
==============================================================================<br>
--- libcxxabi/trunk/cmake/config-ix.cmake (original)<br>
+++ libcxxabi/trunk/cmake/config-ix.cmake Thu Jun  2 03:14:28 2016<br>
@@ -8,7 +8,6 @@ check_cxx_compiler_flag(-fPIC<br>
 check_cxx_compiler_flag(-fno-exceptions       LIBCXXABI_HAS_NO_EXCEPTIONS_FLAG)<br>
 check_cxx_compiler_flag(-fno-rtti             LIBCXXABI_HAS_NO_RTTI_FLAG)<br>
 check_cxx_compiler_flag(-fstrict-aliasing     LIBCXXABI_HAS_FSTRICT_ALIASING_FLAG)<br>
-check_cxx_compiler_flag(-fvisibility=hidden   LIBCXXABI_HAS_FVISIBILITY_HIDDEN_FLAG)<br>
 check_cxx_compiler_flag(-nodefaultlibs        LIBCXXABI_HAS_NODEFAULTLIBS_FLAG)<br>
 check_cxx_compiler_flag(-nostdinc++           LIBCXXABI_HAS_NOSTDINCXX_FLAG)<br>
 check_cxx_compiler_flag(-Wall                 LIBCXXABI_HAS_WALL_FLAG)<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>