<div dir="ltr">> <span style="font-size:12.8px">As for tests - XFAILing seems a bit general when there's really not much value in running any of the tests anyway. REQUIRES, perhaps? </span><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Unfortunately REQUIRES is a conjunction so the obvious "// REQUIRES: c++98, c++03, c++11, c++14" won't work. </span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 26, 2016 at 11:32 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">NO_REMOVE seems like a strange way of saying it - is there existing precedent for that naming/description? (rather than something like _LIBCPP_PROVIDE_AUTOPTR ?<br><br>As for tests - XFAILing seems a bit general when there's really not much value in running any of the tests anyway. REQUIRES, perhaps? (that does bring the issue I assume Eric is alluding to forward a bit (I assume what he's alluding to is that when we have c++2x then we'd have to say XFAIL c++1z c++2x and so on - switching it around we /already/ have the problem that we'd want the auto_ptr tests to REQUIRE c++11, c++14 or whatever)) & maybe having an explicit test or two for the negative case (I would worry that XFAIL would be too vague "this should fail somehow... "). But maybe that's all unnecessary paranoia.<br><br>- Dave</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Wed, May 25, 2016 at 9:28 PM, Marshall Clow via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">mclow.lists created this revision.<br>
mclow.lists added a reviewer: EricWF.<br>
mclow.lists added a subscriber: cfe-commits.<br>
<br>
[[ <a href="http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4190" rel="noreferrer" target="_blank">http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4190</a> | N4190 ]] removed `auto_ptr` from C++1z. (and other stuff)<br>
<br>
Wrap all the auto_ptr bits in an #ifdef so they disappear when compiling with `-std=c++1z` or later.<br>
<br>
Introduce a new configuration option, `_LIBCPP_NO_REMOVE_AUTOPTR` which allows user code to continue using `auto_ptr` in C++1z mode if desired.<br>
<br>
Add a test for `_LIBCPP_NO_REMOVE_AUTOPTR`, and mark all the rest of the `auto_ptr` tests to XFAIL for c++1z<br>
<br>
<a href="http://reviews.llvm.org/D20660" rel="noreferrer" target="_blank">http://reviews.llvm.org/D20660</a><br>
<br>
Files:<br>
include/memory<br>
test/libcxx/depr/depr.auto.ptr/auto.ptr/auto_ptr.cxx1z.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.cons/assignment.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.cons/convert.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.cons/convert_assignment.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.cons/copy.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.cons/pointer.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.conv/assign_from_auto_ptr_ref.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.conv/convert_from_auto_ptr_ref.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.conv/convert_to_auto_ptr.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.conv/convert_to_auto_ptr_ref.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.members/arrow.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.members/deref.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.members/release.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.members/reset.pass.cpp<br>
test/std/depr/depr.auto.ptr/auto.ptr/element_type.pass.cpp<br>
<br>
<br></div></div>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>