<div dir="ltr">Thank you for fixing this!</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 18, 2016 at 11:48 AM, Benjamin Kramer via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Wed May 18 04:48:46 2016<br>
New Revision: 269896<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=269896&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=269896&view=rev</a><br>
Log:<br>
[clang-tidy] Fix a functional change from r269656.<br>
<br>
Instead of forming char ranges that patch made us form token ranges,<br>
which behave subtly different. Sadly I'm only seeing this as part of a<br>
larger test case that I haven't fully reduced yet.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-tidy/utils/IncludeSorter.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/utils/IncludeSorter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/utils/IncludeSorter.cpp?rev=269896&r1=269895&r2=269896&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/utils/IncludeSorter.cpp?rev=269896&r1=269895&r2=269896&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/utils/IncludeSorter.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/utils/IncludeSorter.cpp Wed May 18 04:48:46 2016<br>
@@ -254,8 +254,8 @@ std::vector<FixItHint> IncludeSorter::Ge<br>
       // Otherwise report the current block edit and start a new block.<br>
     } else {<br>
       if (CurrentEndLine) {<br>
-        Fixes.push_back(<br>
-            FixItHint::CreateReplacement(CurrentRange, CurrentText));<br>
+        Fixes.push_back(FixItHint::CreateReplacement(<br>
+            CharSourceRange::getCharRange(CurrentRange), CurrentText));<br>
       }<br>
<br>
       CurrentEndLine = LineEdit.first;<br>
@@ -265,7 +265,8 @@ std::vector<FixItHint> IncludeSorter::Ge<br>
   }<br>
   // Finally, report the current block edit if there is one.<br>
   if (CurrentEndLine) {<br>
-    Fixes.push_back(FixItHint::CreateReplacement(CurrentRange, CurrentText));<br>
+    Fixes.push_back(FixItHint::CreateReplacement(<br>
+        CharSourceRange::getCharRange(CurrentRange), CurrentText));<br>
   }<br>
<br>
   // Reset the remaining internal state.<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>