Er, why? Why not just disable this warning in chromium?<div>Clangs diagnostics wouldn't have developed as well as they have if we took this approach to all <span></span>warnings.<br><br>On Tuesday, May 10, 2016, Hans Wennborg via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hans<br>
Date: Tue May 10 19:49:20 2016<br>
New Revision: 269148<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=269148&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=269148&view=rev</a><br>
Log:<br>
Disable -Wcast-calling-convention by default (follow-up to r269116)<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
    cfe/trunk/test/Sema/callingconv-cast.c<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=269148&r1=269147&r2=269148&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=269148&r1=269147&r2=269148&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue May 10 19:49:20 2016<br>
@@ -6625,7 +6625,7 @@ def warn_function_def_in_objc_container<br>
 def warn_cast_calling_conv : Warning<<br>
   "cast between incompatible calling conventions '%0' and '%1'; "<br>
   "calls through this pointer may abort at runtime">,<br>
-  InGroup<DiagGroup<"cast-calling-convention">>;<br>
+  InGroup<DiagGroup<"cast-calling-convention">>, DefaultIgnore;<br>
 def note_change_calling_conv_fixit : Note<<br>
   "consider defining %0 with the '%1' calling convention">;<br>
 def warn_bad_function_cast : Warning<<br>
<br>
Modified: cfe/trunk/test/Sema/callingconv-cast.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/callingconv-cast.c?rev=269148&r1=269147&r2=269148&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/callingconv-cast.c?rev=269148&r1=269147&r2=269148&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Sema/callingconv-cast.c (original)<br>
+++ cfe/trunk/test/Sema/callingconv-cast.c Tue May 10 19:49:20 2016<br>
@@ -3,6 +3,9 @@<br>
 // RUN: %clang_cc1 -fms-extensions -triple i686-pc-windows-msvc -Wcast-calling-convention -DMSVC -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s --check-prefix=MSFIXIT<br>
 // RUN: %clang_cc1 -triple i686-pc-windows-gnu -Wcast-calling-convention -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s --check-prefix=GNUFIXIT<br>
<br>
+// Check that the warning is disabled by default:<br>
+// RUN: %clang_cc1 -fms-extensions -triple i686-pc-windows-msvc -DMSVC -Werror -Wno-pointer-bool-conversion -x c %s<br>
+<br>
 // expected-note@+1 {{consider defining 'mismatched_before_winapi' with the 'stdcall' calling convention}}<br>
 void mismatched_before_winapi(int x) {}<br>
<br>
@@ -43,12 +46,12 @@ int main() {<br>
   take_callback((callback_t)(void*)mismatched);<br>
 }<br>
<br>
-// MSFIXIT: fix-it:"{{.*}}callingconv-cast.c":{16:6-16:6}:"WINAPI "<br>
-// MSFIXIT: fix-it:"{{.*}}callingconv-cast.c":{16:6-16:6}:"WINAPI "<br>
-// MSFIXIT: fix-it:"{{.*}}callingconv-cast.c":{16:6-16:6}:"WINAPI "<br>
-// MSFIXIT: fix-it:"{{.*}}callingconv-cast.c":{7:6-7:6}:"__stdcall "<br>
-<br>
-// GNUFIXIT: fix-it:"{{.*}}callingconv-cast.c":{16:6-16:6}:"WINAPI "<br>
-// GNUFIXIT: fix-it:"{{.*}}callingconv-cast.c":{16:6-16:6}:"WINAPI "<br>
-// GNUFIXIT: fix-it:"{{.*}}callingconv-cast.c":{16:6-16:6}:"WINAPI "<br>
-// GNUFIXIT: fix-it:"{{.*}}callingconv-cast.c":{7:6-7:6}:"__attribute__((stdcall)) "<br>
+// MSFIXIT: fix-it:"{{.*}}callingconv-cast.c":{19:6-19:6}:"WINAPI "<br>
+// MSFIXIT: fix-it:"{{.*}}callingconv-cast.c":{19:6-19:6}:"WINAPI "<br>
+// MSFIXIT: fix-it:"{{.*}}callingconv-cast.c":{19:6-19:6}:"WINAPI "<br>
+// MSFIXIT: fix-it:"{{.*}}callingconv-cast.c":{10:6-10:6}:"__stdcall "<br>
+<br>
+// GNUFIXIT: fix-it:"{{.*}}callingconv-cast.c":{19:6-19:6}:"WINAPI "<br>
+// GNUFIXIT: fix-it:"{{.*}}callingconv-cast.c":{19:6-19:6}:"WINAPI "<br>
+// GNUFIXIT: fix-it:"{{.*}}callingconv-cast.c":{19:6-19:6}:"WINAPI "<br>
+// GNUFIXIT: fix-it:"{{.*}}callingconv-cast.c":{10:6-10:6}:"__attribute__((stdcall)) "<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="javascript:;" onclick="_e(event, 'cvml', 'cfe-commits@lists.llvm.org')">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>