<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, May 6, 2016 at 5:43 PM, Yaron Keren via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="rtl"><div dir="ltr">Hi Nico,</div><div dir="ltr"><br></div><div dir="ltr">In other tests, {{/|\\\\}} or {{/|\\}} are used match the forward or backward slash(es). clang escapes \ so we get two of them in output and four in the LIT test.</div><div dir="ltr"><br></div><div dir="ltr">It would be nice to have more elegant construct for this general problem, to avoid tests like:<br></div><div dir="ltr"><br></div><div dir="ltr">"{{.*}}/Inputs/mingw_mingw_org_tree/mingw{{/|\\\\}}lib{{/|\\\\}}gcc{{/|\\\\}}mingw32{{/|\\\\}}4.8.1{{/|\\\\}}include{{/|\\\\}}c++"<br></div><div dir="ltr"><br></div><div dir="ltr">maybe having FileCheck allow  / match \ when running under Windows?</div></div></blockquote><div><br></div><div>Seems overly magical to me. Maybe we should use {{.}} instead of {{/|\\\\}} unless it's really important it's a slash or backslash for the test ;-)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="rtl"><div dir="ltr"><br></div><div dir="ltr">Yaron</div><div dir="ltr"><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2016-05-07 0:17 GMT+03:00 Nico Weber via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nico<br>
Date: Fri May  6 16:17:32 2016<br>
New Revision: 268797<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=268797&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=268797&view=rev</a><br>
Log:<br>
Fix sysroot-prefix.c on Windows (/ vs \).<br>
<br>
Modified:<br>
    cfe/trunk/test/Preprocessor/sysroot-prefix.c<br>
<br>
Modified: cfe/trunk/test/Preprocessor/sysroot-prefix.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/sysroot-prefix.c?rev=268797&r1=268796&r2=268797&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/sysroot-prefix.c?rev=268797&r1=268796&r2=268797&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Preprocessor/sysroot-prefix.c (original)<br>
+++ cfe/trunk/test/Preprocessor/sysroot-prefix.c Fri May  6 16:17:32 2016<br>
@@ -14,12 +14,12 @@<br>
 // CHECK-NO_ISYSROOT_SYSROOT_DEV_NULL: ignoring nonexistent directory "=/var/empty/include"<br>
 // CHECK-NO_ISYSROOT_SYSROOT_DEV_NULL-NOT: ignoring nonexistent directory "/var/empty/include"<br>
<br>
-// CHECK-ISYSROOT_SYSROOT_NULL: ignoring nonexistent directory "/var/empty/null"<br>
+// CHECK-ISYSROOT_SYSROOT_NULL: ignoring nonexistent directory "/var/empty{{.}}null"<br>
 // CHECK-ISYSROOT_SYSROOT_NULL-NOT: ignoring nonexistent directory "=null"<br>
<br>
-// CHECK-ISYSROOT_ISYSROOT_SYSROOT_NULL: ignoring nonexistent directory "/var/empty/root/null"<br>
+// CHECK-ISYSROOT_ISYSROOT_SYSROOT_NULL: ignoring nonexistent directory "/var/empty/root{{.}}null"<br>
 // CHECK-ISYSROOT_ISYSROOT_SYSROOT_NULL-NOT: ignoring nonexistent directory "=null"<br>
<br>
-// CHECK-ISYSROOT_ISYSROOT_SWAPPED_SYSROOT_NULL: ignoring nonexistent directory "/var/empty/null"<br>
+// CHECK-ISYSROOT_ISYSROOT_SWAPPED_SYSROOT_NULL: ignoring nonexistent directory "/var/empty{{.}}null"<br>
 // CHECK-ISYSROOT_ISYSROOT_SWAPPED_SYSROOT_NULL-NOT: ignoring nonexistent directory "=null"<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>