<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 14, 2016 at 4:09 AM, Ismail Donmez via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Hi,<br>
<span class="gmail-"><br>
On Tue, Apr 12, 2016 at 10:04 PM, Nico Weber via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: nico<br>
> Date: Tue Apr 12 14:04:37 2016<br>
> New Revision: 266108<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=266108&view=rev" rel="noreferrer">http://llvm.org/viewvc/llvm-project?rev=266108&view=rev</a><br>
> Log:<br>
> clang-cl: Remove -isystem, add -imsvc.<br>
><br>
> r260990 exposed -isystem in clang-cl. -isystem adds a directory to the front of<br>
> the system include search path. The idea was to use this to point to a hermetic<br>
> msvc install, but as it turns out this doesn't work: -isystem then adds the<br>
> hermetic headers in front of clang's builtin headers, and clang's headers that<br>
> are supposed to wrap msvc headers (say, stdarg.h) aren't picked up at all<br>
> anymore.<br>
><br>
> So revert that, and instead expose -imsvc which works as if the passed<br>
> directory was part of %INCLUDE%: The header is treated as a system header, but<br>
> it is searched after clang's lib/Header headers.<br>
><br>
> Fixes half of PRPR26751.<br>
<br>
</span>This fails the test for me on Linux x86-64:<br>
<br>
/home/abuild/rpmbuild/BUILD/llvm/stage2/./bin/clang --driver-mode=cl<br>
--driver-mode=cl -fcolor-diagnostics<br>
-fno-color-diagnostics -fdiagnostics-color<br>
-fno-diagnostics-color -fdiagnostics-parseable-fixits<br>
-ferror-limit=10 -fmsc-version=1800 -fno-strict-aliasing<br>
-fstrict-aliasing -fsyntax-only -fms-compatibility<br>
-fno-ms-compatibility -fms-extensions -fno-ms-extensions<br>
-mllvm -disable-llvm-optzns -Wunused-variable<br>
-fmacro-backtrace-limit=0 -Werror /Zs --<br>
/home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/Driver/cl-options.c<br>
2>&1<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stderr):<br>
--<br>
/home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/Driver/cl-options.c:88:17:<br>
error: expected string not found in input<br>
// SLASH_imsvc: "-internal-isystem"<br>
"{{[^"]*}}lib{{/|\\\\}}clang{{[^"]*}}include"<br>
^<br>
<stdin>:1:1: note: scanning from here<br>
openSUSE Linux clang version 3.9.0 (trunk 266277) (based on LLVM 3.9.0svn)<br>
^<br>
<stdin>:5:709: note: possible intended match here<br>
"/home/abuild/rpmbuild/BUILD/llvm/stage2/bin/clang-3.9" "-cc1"<br>
"-triple" "x86_64-pc-windows-msvc18.0.0" "-emit-obj" "-mrelax-all"<br>
"-mincremental-linker-compatible" "-disable-free"<br>
"-disable-llvm-verifier" "-discard-value-names" "-main-file-name"<br>
"cl-options.c" "-mrelocation-model" "pic" "-pic-level" "2"<br>
"-mthread-model" "posix" "-relaxed-aliasing" "-fmath-errno"<br>
"-masm-verbose" "-mconstructor-aliases" "-munwind-tables"<br>
"-target-cpu" "x86-64" "-D_MT" "--dependent-lib=libcmt"<br>
"--dependent-lib=oldnames" "-fms-volatile" "-fdiagnostics-format"<br>
"msvc" "-momit-leaf-frame-pointer" "-dwarf-column-info"<br>
"-debugger-tuning=gdb" "-resource-dir"<br>
"/home/abuild/rpmbuild/BUILD/llvm/stage2/bin/../lib64/clang/3.9.0"<br>
"-internal-isystem"<br>
"/home/abuild/rpmbuild/BUILD/llvm/stage2/bin/../lib64/clang/3.9.0/include"<br>
"-internal-isystem" "myincludedir" "-internal-isystem" "C:/Program<br>
Files/Microsoft Visual Studio 10.0/VC/include" "-internal-isystem"<br>
"C:/Program Files/Microsoft Visual Studio 9.0/VC/include"<br>
"-internal-isystem" "C:/Program Files/Microsoft Visual Studio<br>
9.0/VC/PlatformSDK/Include" "-internal-isystem" "C:/Program<br>
Files/Microsoft Visual Studio 8/VC/include" "-internal-isystem"<br>
"C:/Program Files/Microsoft Visual Studio 8/VC/PlatformSDK/Include"<br>
"-fdebug-compilation-dir"<br>
"/home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/Driver"<br>
"-ferror-limit" "19" "-fmessage-length" "0" "-fms-extensions"<br>
"-fms-compatibility" "-fms-compatibility-version=18"<br>
"-fno-threadsafe-statics" "-fdelayed-template-parsing"<br>
"-fobjc-runtime=gcc" "-fdiagnostics-show-option" "-o"<br>
"/tmp/cl-options-ca1c04.obj" "-x" "c"<br>
"/home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/Driver/cl-options.c"<br></blockquote><div><br></div><div>It's supposed to match the</div><div><br></div><div><div>"-internal-isystem"</div><div>"/home/abuild/rpmbuild/BUILD/llvm/stage2/bin/../lib64/clang/3.9.0/include"</div><div>"-internal-isystem" "myincludedir" </div></div><div><br></div><div>bit in your output. Looks like it's "lib64" instead of "lib" on your system. Does changing</div><div><br></div><div><div>// SLASH_imsvc: "-internal-isystem" "{{[^"]*}}lib{{/|\\\\}}clang{{[^"]*}}include"</div></div><div><br></div><div>to</div><div><br></div><div><div>// SLASH_imsvc: "-internal-isystem" "{{[^"]*}}lib{{(64)?/|\\\\}}clang{{[^"]*}}include"</div></div><div><br></div><div>help?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
Any ideas?<br>
<div class="gmail-HOEnZb"><div class="gmail-h5">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>