<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Mon, Mar 7, 2016 at 12:33 AM Michael Zuckerman via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mzuckerm<br>
Date: Mon Mar  7 02:29:10 2016<br>
New Revision: 262817<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262817&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262817&view=rev</a><br>
Log:<br>
[CLANG][AVX512][BUILTIN] Adding vpmultishiftqb{128|256|512}<br></blockquote><div><br></div><div>This commit log seems super confusing combined with:</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+TARGET_BUILTIN(__builtin_ia32_pbroadcastb512_gpr_mask, "V64ccV64cULLi","","avx512bw")<br>
+TARGET_BUILTIN(__builtin_ia32_pbroadcastb128_gpr_mask, "V16ccV16cUs","","avx512bw,avx512vl")<br>
+TARGET_BUILTIN(__builtin_ia32_pbroadcastb256_gpr_mask, "V32ccV32cUi","","avx512bw,avx512vl")<br>
+TARGET_BUILTIN(__builtin_ia32_pbroadcastd128_gpr_mask, "V4iiV4iUc","","avx512vl")<br>
+TARGET_BUILTIN(__builtin_ia32_pbroadcastd256_gpr_mask, "V8iiV8iUc","","avx512vl")<br>
+TARGET_BUILTIN(__builtin_ia32_pbroadcastq128_gpr_mask, "V2LLiULLiV2LLiUc","","avx512vl")<br>
+TARGET_BUILTIN(__builtin_ia32_pbroadcastq256_gpr_mask, "V4LLiULLiV4LLiUc","","avx512vl")<br></blockquote><div><br></div><div>This is adding *broadcast* intrinsics!!! Not multishift!</div><div><br></div><div>Please be much more careful with your patch descriptions. I just happened to randomly notice this.</div><div><br></div><div>Elena, please actually carefully review these patches.</div></div></div>