<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 7, 2016 at 5:05 PM, Reid Kleckner via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">rnk updated this revision to Diff 52982.<br>
rnk marked 3 inline comments as done.<br>
rnk added a comment.<br>
<br>
- Add -Wshadow-all and -Wshadow-field-in-constructor, also address review comments<br></blockquote><div><br>Strikes me as strange that we're adding a new name for a flag that matches the behavior of GCC's -Wshadow, rather than introducing the better one under a new name. (that way people already using it would continue to get the same behavior - people who came from GCC would get the same behavior they were already getting, etc)<br><br>But I'll leave it to you guys to decide how that all shakes out.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<a href="http://reviews.llvm.org/D18271" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18271</a><br>
<br>
Files:<br>
  include/clang/Basic/Diagnostic.h<br>
  include/clang/Basic/DiagnosticGroups.td<br>
  include/clang/Basic/DiagnosticSemaKinds.td<br>
  include/clang/Sema/Sema.h<br>
  lib/Sema/AnalysisBasedWarnings.cpp<br>
  lib/Sema/SemaDecl.cpp<br>
  lib/Sema/SemaExpr.cpp<br>
  test/SemaCXX/warn-shadow.cpp<br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>