<div dir="ltr">I'm not sure I understand what this test has to do with VS2013. Clang-tidy should be able to parse this code, and if it doesn't (e.g. due to -fms-compatibility being turned on by default on windows), we should put unsupported constructs under an appropriate #ifdef, not comment them out completely.<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 28, 2016 at 6:15 AM, Richard Thomson via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: legalize<br>
Date: Sun Mar 27 23:15:41 2016<br>
New Revision: 264563<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=264563&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=264563&view=rev</a><br>
Log:<br>
clang-tidy: Fix broken buildbot<br>
<br>
VS 2013 does not support char16_t or char32_t<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp?rev=264563&r1=264562&r2=264563&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp?rev=264563&r1=264562&r2=264563&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp (original)<br>
+++ clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp Sun Mar 27 23:15:41 2016<br>
@@ -46,10 +46,12 @@ char const *const TrailingNewLine("A sin<br>
 char const *const AlreadyRaw(R"(foobie\\bletch)");<br>
 char const *const UTF8Literal(u8"foobie\\bletch");<br>
 char const *const UTF8RawLiteral(u8R"(foobie\\bletch)");<br>
-char16_t const *const UTF16Literal(u"foobie\\bletch");<br>
-char16_t const *const UTF16RawLiteral(uR"(foobie\\bletch)");<br>
-char32_t const *const UTF32Literal(U"foobie\\bletch");<br>
-char32_t const *const UTF32RawLiteral(UR"(foobie\\bletch)");<br>
+// TODO: enable these tests once all supported compilers<br>
+// support char16_t and char32_t (VS2013 does not)<br>
+// char16_t const *const UTF16Literal(u"foobie\\bletch");<br>
+// char16_t const *const UTF16RawLiteral(uR"(foobie\\bletch)");<br>
+// char32_t const *const UTF32Literal(U"foobie\\bletch");<br>
+// char32_t const *const UTF32RawLiteral(UR"(foobie\\bletch)");<br>
 wchar_t const *const WideLiteral(L"foobie\\bletch");<br>
 wchar_t const *const WideRawLiteral(LR"(foobie\\bletch)");<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>