<div dir="ltr">Thanks for letting me know! Should be fixed in r264862.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 30, 2016 at 2:19 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This doesn't build on Windows:<div><br></div><div><a href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11018/steps/build%20stage%201/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11018/steps/build%20stage%201/logs/stdio</a><br></div><div><br></div><div><div>d:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\tools\extra\clang-tidy\readability\../ClangTidyModule.h(61) : error C2660: 'clang::tidy::readability::AvoidConstParamsInDecls::AvoidConstParamsInDecls' : function does not take 2 arguments</div><div> D:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\tools\extra\clang-tidy\readability\ReadabilityTidyModule.cpp(37) : see reference to function template instantiation 'void clang::tidy::ClangTidyCheckFactories::registerCheck<clang::tidy::readability::AvoidConstParamsInDecls>(llvm::StringRef)' being compiled</div></div><div><br></div><div>Can you take a look?</div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 30, 2016 at 4:31 AM, Alexander Kornienko via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alexfh<br>
Date: Wed Mar 30 06:31:33 2016<br>
New Revision: 264856<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=264856&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=264856&view=rev</a><br>
Log:<br>
[clang-tidy] readability check for const params in declarations<br>
<br>
Summary: Adds a clang-tidy warning for top-level consts in function declarations.<br>
<br>
Reviewers: hokein, sbenza, alexfh<br>
<br>
Subscribers: cfe-commits<br>
<br>
Patch by Matt Kulukundis!<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D18408" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18408</a><br>
<br>
Added:<br>
clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.cpp<br>
clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.h<br>
clang-tools-extra/trunk/docs/clang-tidy/checks/readability-avoid-const-params-in-decls.rst<br>
clang-tools-extra/trunk/test/clang-tidy/readability-avoid-const-params-in-decls.cpp<br>
Modified:<br>
clang-tools-extra/trunk/clang-tidy/readability/CMakeLists.txt<br>
clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp<br>
clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst<br>
<br>
Added: clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.cpp?rev=264856&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.cpp?rev=264856&view=auto</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.cpp (added)<br>
+++ clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.cpp Wed Mar 30 06:31:33 2016<br>
@@ -0,0 +1,71 @@<br>
+//===--- AvoidConstParamsInDecls.cpp - clang-tidy--------------------------===//<br>
+//<br>
+// The LLVM Compiler Infrastructure<br>
+//<br>
+// This file is distributed under the University of Illinois Open Source<br>
+// License. See LICENSE.TXT for details.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+#include "AvoidConstParamsInDecls.h"<br>
+#include "clang/ASTMatchers/ASTMatchFinder.h"<br>
+#include "clang/ASTMatchers/ASTMatchers.h"<br>
+#include "clang/Lex/Lexer.h"<br>
+<br>
+using namespace clang::ast_matchers;<br>
+<br>
+namespace clang {<br>
+namespace tidy {<br>
+namespace readability {<br>
+namespace {<br>
+<br>
+SourceRange getTypeRange(const ParmVarDecl &Param) {<br>
+ if (Param.getIdentifier() != nullptr)<br>
+ return SourceRange(Param.getLocStart(),<br>
+ Param.getLocEnd().getLocWithOffset(-1));<br>
+ return Param.getSourceRange();<br>
+}<br>
+<br>
+} // namespace<br>
+<br>
+<br>
+void AvoidConstParamsInDecls::registerMatchers(MatchFinder *Finder) {<br>
+ const auto ConstParamDecl =<br>
+ parmVarDecl(hasType(qualType(isConstQualified()))).bind("param");<br>
+ Finder->addMatcher(functionDecl(unless(isDefinition()),<br>
+ has(typeLoc(forEach(ConstParamDecl))))<br>
+ .bind("func"),<br>
+ this);<br>
+}<br>
+<br>
+void AvoidConstParamsInDecls::check(const MatchFinder::MatchResult &Result) {<br>
+ const auto *Func = Result.Nodes.getNodeAs<FunctionDecl>("func");<br>
+ const auto *Param = Result.Nodes.getNodeAs<ParmVarDecl>("param");<br>
+<br>
+ QualType Type = Param->getType();<br>
+ if (!Type.isLocalConstQualified())<br>
+ return;<br>
+<br>
+ Type.removeLocalConst();<br>
+<br>
+ auto Diag = diag(Param->getLocStart(),<br>
+ "parameter %0 is const-qualified in the function "<br>
+ "declaration; const-qualification of parameters only has an "<br>
+ "effect in function definitions");<br>
+ if (Param->getName().empty()) {<br>
+ for (unsigned int i = 0; i < Func->getNumParams(); ++i) {<br>
+ if (Param == Func->getParamDecl(i)) {<br>
+ Diag << (i + 1);<br>
+ break;<br>
+ }<br>
+ }<br>
+ } else {<br>
+ Diag << Param;<br>
+ }<br>
+ Diag << FixItHint::CreateReplacement(getTypeRange(*Param),<br>
+ Type.getAsString());<br>
+}<br>
+<br>
+} // namespace readability<br>
+} // namespace tidy<br>
+} // namespace clang<br>
<br>
Added: clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.h?rev=264856&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.h?rev=264856&view=auto</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.h (added)<br>
+++ clang-tools-extra/trunk/clang-tidy/readability/AvoidConstParamsInDecls.h Wed Mar 30 06:31:33 2016<br>
@@ -0,0 +1,33 @@<br>
+//===--- AvoidConstParamsInDecls.h - clang-tidy----------------------------===//<br>
+//<br>
+// The LLVM Compiler Infrastructure<br>
+//<br>
+// This file is distributed under the University of Illinois Open Source<br>
+// License. See LICENSE.TXT for details.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_AVOID_CONST_PARAMS_IN_DECLS_H<br>
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_AVOID_CONST_PARAMS_IN_DECLS_H<br>
+<br>
+#include "../ClangTidy.h"<br>
+<br>
+namespace clang {<br>
+namespace tidy {<br>
+namespace readability {<br>
+<br>
+// Detect function declarations that have const value parameters and discourage<br>
+// them.<br>
+class AvoidConstParamsInDecls : public ClangTidyCheck {<br>
+public:<br>
+ using ClangTidyCheck::ClangTidyCheck;<br>
+<br>
+ void registerMatchers(ast_matchers::MatchFinder *Finder) override;<br>
+ void check(const ast_matchers::MatchFinder::MatchResult &Result) override;<br>
+};<br>
+<br>
+} // namespace readability<br>
+} // namespace tidy<br>
+} // namespace clang<br>
+<br>
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_AVOID_CONST_PARAMS_IN_DECLS_H<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/readability/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/CMakeLists.txt?rev=264856&r1=264855&r2=264856&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/CMakeLists.txt?rev=264856&r1=264855&r2=264856&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/readability/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/readability/CMakeLists.txt Wed Mar 30 06:31:33 2016<br>
@@ -1,6 +1,7 @@<br>
set(LLVM_LINK_COMPONENTS support)<br>
<br>
add_clang_library(clangTidyReadabilityModule<br>
+ AvoidConstParamsInDecls.cpp<br>
BracesAroundStatementsCheck.cpp<br>
ContainerSizeEmptyCheck.cpp<br>
ElseAfterReturnCheck.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp?rev=264856&r1=264855&r2=264856&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp?rev=264856&r1=264855&r2=264856&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp Wed Mar 30 06:31:33 2016<br>
@@ -10,6 +10,7 @@<br>
#include "../ClangTidy.h"<br>
#include "../ClangTidyModule.h"<br>
#include "../ClangTidyModuleRegistry.h"<br>
+#include "AvoidConstParamsInDecls.h"<br>
#include "BracesAroundStatementsCheck.h"<br>
#include "ContainerSizeEmptyCheck.h"<br>
#include "ElseAfterReturnCheck.h"<br>
@@ -32,6 +33,8 @@ namespace readability {<br>
class ReadabilityModule : public ClangTidyModule {<br>
public:<br>
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {<br>
+ CheckFactories.registerCheck<AvoidConstParamsInDecls>(<br>
+ "readability-avoid-const-params-in-decls");<br>
CheckFactories.registerCheck<BracesAroundStatementsCheck>(<br>
"readability-braces-around-statements");<br>
CheckFactories.registerCheck<ContainerSizeEmptyCheck>(<br>
<br>
Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst?rev=264856&r1=264855&r2=264856&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst?rev=264856&r1=264855&r2=264856&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst (original)<br>
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Wed Mar 30 06:31:33 2016<br>
@@ -90,8 +90,9 @@ Clang-Tidy Checks<br>
performance-faster-string-find<br>
performance-for-range-copy<br>
performance-implicit-cast-in-loop<br>
- performance-unnecessary-value-param<br>
performance-unnecessary-copy-initialization<br>
+ performance-unnecessary-value-param<br>
+ readability-avoid-const-params-in-decls<br>
readability-braces-around-statements<br>
readability-container-size-empty<br>
readability-else-after-return<br>
<br>
Added: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-avoid-const-params-in-decls.rst<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/readability-avoid-const-params-in-decls.rst?rev=264856&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/readability-avoid-const-params-in-decls.rst?rev=264856&view=auto</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/docs/clang-tidy/checks/readability-avoid-const-params-in-decls.rst (added)<br>
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/readability-avoid-const-params-in-decls.rst Wed Mar 30 06:31:33 2016<br>
@@ -0,0 +1,17 @@<br>
+.. title:: clang-tidy - readability-avoid-const-params-in-decls<br>
+<br>
+readability-avoid-const-params-in-decls<br>
+=======================================<br>
+<br>
+Checks whether a function declaration has parameters that are top level const.<br>
+<br>
+`const` values in declarations do not affect the signature of a function, so<br>
+they should not be put there. For example:<br>
+<br>
+Examples:<br>
+<br>
+.. code:: c++<br>
+<br>
+ void f(const string); // Bad: const is top level.<br>
+ void f(const string&); // Good: const is not top level.<br>
+<br>
<br>
Added: clang-tools-extra/trunk/test/clang-tidy/readability-avoid-const-params-in-decls.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-avoid-const-params-in-decls.cpp?rev=264856&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-avoid-const-params-in-decls.cpp?rev=264856&view=auto</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-tidy/readability-avoid-const-params-in-decls.cpp (added)<br>
+++ clang-tools-extra/trunk/test/clang-tidy/readability-avoid-const-params-in-decls.cpp Wed Mar 30 06:31:33 2016<br>
@@ -0,0 +1,78 @@<br>
+// RUN: %check_clang_tidy %s readability-avoid-const-params-in-decls %t<br>
+<br>
+using alias_type = bool;<br>
+using alias_const_type = const bool;<br>
+<br>
+<br>
+void F1(const int i);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: parameter 'i' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]<br>
+// CHECK-FIXES: void F1(int i);<br>
+<br>
+void F2(const int *const i);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: parameter 'i' is const-qualified<br>
+// CHECK-FIXES: void F2(const int * i);<br>
+<br>
+void F3(int const i);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: parameter 'i' is const-qualified<br>
+// CHECK-FIXES: void F3(int i);<br>
+<br>
+void F4(alias_type const i);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: parameter 'i' is const-qualified<br>
+// CHECK-FIXES: void F4(alias_type i);<br>
+<br>
+void F5(const int);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: parameter 1 is const-qualified<br>
+// CHECK-FIXES: void F5(int);<br>
+<br>
+void F6(const int *const);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: parameter 1 is const-qualified<br>
+// BUG(b/27584482): void F6(const int *); should be produced<br>
+<br>
+void F7(int, const int);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: parameter 2 is const-qualified<br>
+// CHECK-FIXES: void F7(int, int);<br>
+<br>
+void F8(const int, const int);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: parameter 1 is const-qualified<br>
+// CHECK-MESSAGES: :[[@LINE-2]]:20: warning: parameter 2 is const-qualified<br>
+// CHECK-FIXES: void F8(int, int);<br>
+<br>
+void F9(const int long_name);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: parameter 'long_name'<br>
+// CHECK-FIXES: void F9(int long_name);<br>
+<br>
+void F10(const int *const *const long_name);<br>
+// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: parameter 'long_name'<br>
+// CHECK-FIXES: void F10(const int *const * long_name);<br>
+<br>
+<br>
+struct Foo {<br>
+ Foo(const int i);<br>
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: parameter 'i'<br>
+ // CHECK-FIXES: Foo(int i);<br>
+<br>
+ void operator()(const int i);<br>
+ // CHECK-MESSAGES: :[[@LINE-1]]:19: warning: parameter 'i'<br>
+ // CHECK-FIXES: void operator()(int i);<br>
+};<br>
+<br>
+// Do not match on definitions<br>
+void NF1(const int i) {}<br>
+void NF2(const int *const i) {}<br>
+void NF3(int const i) {}<br>
+void NF4(alias_type const i) {}<br>
+void NF5(const int) {}<br>
+void NF6(const int *const) {}<br>
+void NF7(int, const int) {}<br>
+void NF8(const int, const int) {}<br>
+<br>
+// Do not match on other stuff<br>
+void NF(const alias_type& i);<br>
+void NF(const int &i);<br>
+void NF(const int *i);<br>
+void NF(alias_const_type i);<br>
+void NF(const alias_type&);<br>
+void NF(const int&);<br>
+void NF(const int*);<br>
+void NF(const int* const*);<br>
+void NF(alias_const_type);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>