<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 25, 2016 at 7:01 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank" class="cremed">richard@metafoo.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" class="cremed">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
><br>
</span><span class="">> On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits<br>
> <<a href="mailto:cfe-commits@lists.llvm.org" class="cremed">cfe-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: sbenza<br>
>> Date: Fri Mar 25 12:46:02 2016<br>
>> New Revision: 264428<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=264428&view=rev" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=264428&view=rev</a><br>
>> Log:<br>
>> [ASTMatchers] Fix build for VariadicFunction.<br>
>><br>
>> Under some conditions the implicit conversion from array to ArrayRef<><br>
>> is not working.<br>
><br>
> Any idea what those conditions are?<br>
<br>
</span>Well, the code's ill-formed (relying on a compiler extension) when<br>
Args is empty. Maybe GCC diagnoses that in some cases?<br></blockquote><div><br></div><div>But Args is never empty on this function.</div><div>It is only every called from the 1+ arg overload of operator().</div><div>There is another overload for the 0-arg case to prevent this problem.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
>> Fix the build by making it explicit.<br>
>><br>
>> Modified:<br>
>>     cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h<br>
>><br>
>> Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h?rev=264428&r1=264427&r2=264428&view=diff" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h?rev=264428&r1=264427&r2=264428&view=diff</a><br>
>><br>
>> ==============================================================================<br>
>> --- cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h (original)<br>
>> +++ cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h Fri Mar 25<br>
>> 12:46:02 2016<br>
>> @@ -90,7 +90,7 @@ private:<br>
>>    // before we make the array.<br>
>>    template <typename... ArgsT> ResultT Execute(const ArgsT &... Args)<br>
>> const {<br>
>>      const ArgT *const ArgsArray[] = {&Args...};<br>
>> -    return Func(ArgsArray);<br>
>> +    return Func(ArrayRef<const ArgT *>(ArgsArray, sizeof...(ArgsT)));<br>
>>    }<br>
>>  };<br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@lists.llvm.org" class="cremed">cfe-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="cremed">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" class="cremed">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="cremed">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
><br>
</div></div></blockquote></div><br></div></div>