<div dir="ltr">Done, however, I don't have commit access, so once it's approved, could you commit it for me?<div><br></div><div>thanks...</div><div>don</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 16, 2016 at 6:00 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Mar 16, 2016 at 11:38 AM, don hinton via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hintonda updated this revision to Diff 50843.<br>
hintonda added a comment.<br>
<br>
Added FIXME comment, and reformated with clang-format.<br>
<span><br>
<br>
<a href="http://reviews.llvm.org/D18123" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18123</a><br>
<br>
Files:<br>
  include/clang/AST/UnresolvedSet.h<br>
  include/clang/Sema/Lookup.h<br>
<br>
Index: include/clang/Sema/Lookup.h<br>
===================================================================<br>
--- include/clang/Sema/Lookup.h<br>
+++ include/clang/Sema/Lookup.h<br>
</span><span>@@ -185,6 +185,11 @@<br>
       Shadowed(false)<br>
   {}<br>
<br>
</span>+  // FIXME: These deleted methods can be removed once the default build includes<br>
+  // both -Werror and -Wdeprecated.<br></blockquote><div><br></div></span><div>I wouldn't worry about the default build being -Werror. It's an option, we keep the build warning clean (we do that by many of us using -Werror, but it's not necessary as such - some buildbots us it too (-Wunused flags often enough)).<br><br>So if you could drop that clause (just leave it as "removed once the default build uses -Wdeprecated", perhaps?)<br><br><br>After taht, please go ahead & commit without the need for another round of review or anything.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
+  LookupResult(const LookupResult &) = delete;<br>
+  LookupResult &operator=(const LookupResult &) = delete;<br>
<span>+<br>
   ~LookupResult() {<br>
     if (Diagnose) diagnose();<br>
     if (Paths) deletePaths(Paths);<br>
Index: include/clang/AST/UnresolvedSet.h<br>
===================================================================<br>
--- include/clang/AST/UnresolvedSet.h<br>
+++ include/clang/AST/UnresolvedSet.h<br>
</span>@@ -59,8 +59,11 @@<br>
<span>   // UnresolvedSet.<br>
 private:<br>
   template <unsigned N> friend class UnresolvedSet;<br>
-  UnresolvedSetImpl() {}<br>
-  UnresolvedSetImpl(const UnresolvedSetImpl &) {}<br>
+  UnresolvedSetImpl() = default;<br>
+  UnresolvedSetImpl(const UnresolvedSetImpl &) = default;<br>
</span>+  UnresolvedSetImpl(UnresolvedSetImpl &&) = default;<br>
+  UnresolvedSetImpl &operator=(const UnresolvedSetImpl &) = default;<br>
+  UnresolvedSetImpl &operator=(UnresolvedSetImpl &&) = default;<br>
<div><div><br>
 public:<br>
   // We don't currently support assignment through this iterator, so we might<br>
<br>
<br>
</div></div><br></span><span class="">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></span></blockquote></div><br></div></div>
</blockquote></div><br></div>