<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 16, 2016 at 7:54 AM, don hinton via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hintonda updated this revision to Diff 50823.<br>
hintonda added a comment.<br>
<br>
Address FIXME now that Sema::LookupInlineAsmField() has been fixed.<br>
<span class=""><br>
<br>
<a href="http://reviews.llvm.org/D18123" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18123</a><br>
<br>
Files:<br>
  include/clang/AST/UnresolvedSet.h<br>
  include/clang/Sema/Lookup.h<br>
<br>
Index: include/clang/Sema/Lookup.h<br>
===================================================================<br>
--- include/clang/Sema/Lookup.h<br>
+++ include/clang/Sema/Lookup.h<br>
@@ -185,6 +185,9 @@<br>
       Shadowed(false)<br>
   {}<br>
<br>
</span>+  LookupResult(const LookupResult &) = delete;<br>
+  LookupResult & operator=(const LookupResult &) = delete;<br></blockquote><div><br></div><div>Not sure how much to bother explicitly deleting ops like this if eventually the -Wdeprecated warning will just catch it that way. Maybe leave a "FIXME: Remove these once the warning for deprecated copy ops is enabled"?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="">+<br>
   ~LookupResult() {<br>
     if (Diagnose) diagnose();<br>
     if (Paths) deletePaths(Paths);<br>
Index: include/clang/AST/UnresolvedSet.h<br>
===================================================================<br>
--- include/clang/AST/UnresolvedSet.h<br>
+++ include/clang/AST/UnresolvedSet.h<br>
</span>@@ -59,8 +59,11 @@<br>
<span class="">   // UnresolvedSet.<br>
 private:<br>
   template <unsigned N> friend class UnresolvedSet;<br>
-  UnresolvedSetImpl() {}<br>
-  UnresolvedSetImpl(const UnresolvedSetImpl &) {}<br>
+  UnresolvedSetImpl() = default;<br>
+  UnresolvedSetImpl(const UnresolvedSetImpl &) = default;<br>
</span>+  UnresolvedSetImpl(UnresolvedSetImpl &&) = default;<br>
<span class="">+  UnresolvedSetImpl& operator=(const UnresolvedSetImpl &) = default;<br>
</span>+  UnresolvedSetImpl& operator=(UnresolvedSetImpl &&) = default;<br>
<div class="HOEnZb"><div class="h5"><br>
 public:<br>
   // We don't currently support assignment through this iterator, so we might<br>
<br>
<br>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>