<div dir="ltr">-Werror clean is great. <div><br></div><div>If you could add -Wdeprecated, then we wouldn't need to delete them -- the warning is only issued with -Wdeprecated is passed. <div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 16, 2016 at 1:49 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Mar 16, 2016 at 10:19 AM, don hinton <span dir="ltr"><<a href="mailto:hintonda@gmail.com" target="_blank">hintonda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The current behavior, albeit deprecated, is to implicitly define these. Therefore, it would be incorrect not to delete them if the implicit versions don't do the right thing.<div><br></div><div>I'd be happy to add a FIXME, but I doubt they will ever be removed. At best, they'd be #ifdef'd away for some future compiler that no longer implicitly defines them.</div><div><br></div><div>Just not sure it's worth it. Deleting them will be valid no matter what the future holds.</div></div></blockquote><div><br></div></span><div>Sure, but it's a lot of extra deletes (if you search the mailing list for "author: dblaikie" and "deprecated" you'll find many other instances I cleaned up, in which we'd have to explicitly delete these ops if that's going to be our approach)<br><br>I don't think we'd only ifdef them away. Keeping the clang build -Werror clean is a pretty well established bar, so if anyone accidentally introduced a call to any of these, we'd find/fix it pretty quickly as we do other errors/mistakes, even when they're not hard language-required errors.</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 16, 2016 at 12:56 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Mar 16, 2016 at 7:54 AM, don hinton via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hintonda updated this revision to Diff 50823.<br>
hintonda added a comment.<br>
<br>
Address FIXME now that Sema::LookupInlineAsmField() has been fixed.<br>
<span><br>
<br>
<a href="http://reviews.llvm.org/D18123" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18123</a><br>
<br>
Files:<br>
include/clang/AST/UnresolvedSet.h<br>
include/clang/Sema/Lookup.h<br>
<br>
Index: include/clang/Sema/Lookup.h<br>
===================================================================<br>
--- include/clang/Sema/Lookup.h<br>
+++ include/clang/Sema/Lookup.h<br>
@@ -185,6 +185,9 @@<br>
Shadowed(false)<br>
{}<br>
<br>
</span>+ LookupResult(const LookupResult &) = delete;<br>
+ LookupResult & operator=(const LookupResult &) = delete;<br></blockquote><div><br></div></span><div>Not sure how much to bother explicitly deleting ops like this if eventually the -Wdeprecated warning will just catch it that way. Maybe leave a "FIXME: Remove these once the warning for deprecated copy ops is enabled"?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
<span>+<br>
~LookupResult() {<br>
if (Diagnose) diagnose();<br>
if (Paths) deletePaths(Paths);<br>
Index: include/clang/AST/UnresolvedSet.h<br>
===================================================================<br>
--- include/clang/AST/UnresolvedSet.h<br>
+++ include/clang/AST/UnresolvedSet.h<br>
</span>@@ -59,8 +59,11 @@<br>
<span> // UnresolvedSet.<br>
private:<br>
template <unsigned N> friend class UnresolvedSet;<br>
- UnresolvedSetImpl() {}<br>
- UnresolvedSetImpl(const UnresolvedSetImpl &) {}<br>
+ UnresolvedSetImpl() = default;<br>
+ UnresolvedSetImpl(const UnresolvedSetImpl &) = default;<br>
</span>+ UnresolvedSetImpl(UnresolvedSetImpl &&) = default;<br>
<span>+ UnresolvedSetImpl& operator=(const UnresolvedSetImpl &) = default;<br>
</span>+ UnresolvedSetImpl& operator=(UnresolvedSetImpl &&) = default;<br>
<div><div><br>
public:<br>
// We don't currently support assignment through this iterator, so we might<br>
<br>
<br>
</div></div><br></span><span>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></span></blockquote></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>