<div dir="ltr">Interesting question going forwards: We usually try to make test cases +/-Asserts agnostic (not using named values), now that we have a flag for it, should we not bother with that & just add the command line argument to enable names when names make testing easier? Or do we think that'll make tests more brittle/depend on unnecessary implementation details?</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Mar 12, 2016 at 6:00 PM, Mehdi AMINI via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">joker.eph created this revision.<br>
joker.eph added reviewers: echristo, chandlerc.<br>
joker.eph added a subscriber: cfe-commits.<br>
<br>
This flag is enabled by default in the driver when NDEBUG is set. It<br>
is forwarded on the LLVMContext to discard all value names (but<br>
GlobalValue) for performance purpose.<br>
<br>
This an improved version of D18024<br>
<br>
<a href="http://reviews.llvm.org/D18127" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18127</a><br>
<br>
Files:<br>
  include/clang/Driver/CC1Options.td<br>
  include/clang/Frontend/CodeGenOptions.def<br>
  lib/CodeGen/CGBuilder.h<br>
  lib/CodeGen/CGCall.cpp<br>
  lib/CodeGen/CGExpr.cpp<br>
  lib/CodeGen/CodeGenFunction.cpp<br>
  lib/CodeGen/ModuleBuilder.cpp<br>
  lib/Driver/Tools.cpp<br>
  lib/Frontend/CompilerInvocation.cpp<br>
  test/CodeGen/mips-byval-arg.c<br>
  test/CodeGen/mips-vector-arg.c<br>
  test/CodeGen/mips-zero-sized-struct.c<br>
  test/CodeGen/mips64-class-return.cpp<br>
  test/CodeGen/mips64-padding-arg.c<br>
  test/CodeGenCXX/debug-info-class.cpp<br>
  test/CodeGenCXX/stack-reuse.cpp<br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>