<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 8, 2016, at 6:28 PM, Ben Langmuir <<a href="mailto:blangmuir@apple.com" class="">blangmuir@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline">On Mar 8, 2016, at 6:12 PM, Argyrios Kyrtzidis via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""><br class="">Author: akirtzidis<br class="">Date: Tue Mar 8 20:12:40 2016<br class="">New Revision: 262984<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262984&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=262984&view=rev</a><br class="">Log:<br class="">[index] Fix assertion hit when indexing re-declarations of built-in functions.<br class=""><br class="">Modified:<br class=""> cfe/trunk/lib/Index/IndexingContext.cpp<br class=""> cfe/trunk/test/Index/Core/index-source.m<br class=""><br class="">Modified: cfe/trunk/lib/Index/IndexingContext.cpp<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/IndexingContext.cpp?rev=262984&r1=262983&r2=262984&view=diff" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/IndexingContext.cpp?rev=262984&r1=262983&r2=262984&view=diff</a><br class="">==============================================================================<br class="">--- cfe/trunk/lib/Index/IndexingContext.cpp (original)<br class="">+++ cfe/trunk/lib/Index/IndexingContext.cpp Tue Mar 8 20:12:40 2016<br class="">@@ -298,6 +298,7 @@ bool IndexingContext::handleDeclOccurren<br class=""> if (Parent)<br class=""> Parent = getCanonicalDecl(Parent);<br class=""> assert(!Parent || !Parent->isImplicit() ||<br class="">+ isa<FunctionDecl>(Parent) ||<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">What is this assertion trying to cover? Can we add a message or comment?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>Checks whether the parent being implicit is expected or not; added a message in r262991, let me know if it is still unclear.</div><br class=""><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> isa<ObjCInterfaceDecl>(Parent) || isa<ObjCMethodDecl>(Parent));<br class=""><br class=""> SmallVector<SymbolRelation, 6> FinalRelations;<br class=""><br class="">Modified: cfe/trunk/test/Index/Core/index-source.m<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/Core/index-source.m?rev=262984&r1=262983&r2=262984&view=diff" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/Core/index-source.m?rev=262984&r1=262983&r2=262984&view=diff</a><br class="">==============================================================================<br class="">--- cfe/trunk/test/Index/Core/index-source.m (original)<br class="">+++ cfe/trunk/test/Index/Core/index-source.m Tue Mar 8 20:12:40 2016<br class="">@@ -65,3 +65,8 @@ enum {<br class=""> // CHECK-NEXT: RelChild | <no-name> | c:@Ea@One<br class=""> Two,<br class="">};<br class="">+<br class="">+// CHECK: [[@LINE+1]]:13 | typedef/C | jmp_buf | c:index-source.m@T@jmp_buf | <no-cgname> | Def | rel: 0<br class="">+typedef int jmp_buf[(18)];<br class="">+// CHECK: [[@LINE+1]]:19 | typedef/C | jmp_buf | c:index-source.m@T@jmp_buf | <no-cgname> | Ref | rel: 0<br class="">+extern int setjmp(jmp_buf);<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</blockquote></div></blockquote></div><br class=""></body></html>