<div dir="ltr">Thanks for the fix! When did it start failing? The last change in this file was quite a while ago. Did it start breaking because of a change in a header?</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 29, 2016 at 10:17 PM, Hans Wennborg via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hans<br>
Date: Mon Feb 29 15:17:39 2016<br>
New Revision: 262257<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262257&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262257&view=rev</a><br>
Log:<br>
IdentifierNamingCheck.cpp: try to fix MSVC build<br>
<br>
It was failing to build with:<br>
<br>
clang-tidy\readability\IdentifierNamingCheck.cpp(640):<br>
error C2882: 'format' : illegal use of namespace identifier in expression<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp?rev=262257&r1=262256&r2=262257&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp?rev=262257&r1=262256&r2=262257&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp Mon Feb 29 15:17:39 2016<br>
@@ -634,10 +634,10 @@ void IdentifierNamingCheck::check(const<br>
     std::string Fixup = fixupWithStyle(Name, Style);<br>
     if (StringRef(Fixup).equals(Name)) {<br>
       if (!IgnoreFailedSplit) {<br>
-        DEBUG(llvm::dbgs() << Decl->getLocStart().printToString(<br>
-                                  *Result.SourceManager)<br>
-                           << format(": unable to split words for %s '%s'\n",<br>
-                                     KindName.c_str(), Name));<br>
+        DEBUG(llvm::dbgs()<br>
+              << Decl->getLocStart().printToString(*Result.SourceManager)<br>
+              << llvm::format(": unable to split words for %s '%s'\n",<br>
+                              KindName.c_str(), Name));<br>
       }<br>
     } else {<br>
       NamingCheckFailure &Failure = NamingCheckFailures[Decl];<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>