<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">This is to reduce stack usage, whether it hits stack overflow or not is highly dependent on configuration.</div><div class="">I've tried forcing smaller stack on the specific test (test/Index/index-many-call-ops.cpp) but then it can hit stack overflow in sema; I don’t have a good way to test this.</div><div class="">I believe asan was also hitting stack overflow and I’m going to try re-enabling for that test.</div><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 29, 2016, at 8:10 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Does this change any behavior? (missing test case?)</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Feb 29, 2016 at 6:46 PM, Argyrios Kyrtzidis via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: akirtzidis<br class="">
Date: Mon Feb 29 20:46:32 2016<br class="">
New Revision: 262290<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262290&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=262290&view=rev</a><br class="">
Log:<br class="">
[index] Fix issue where data visitation was disabled with C++ operator call expressions, during indexing.<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/lib/Index/IndexBody.cpp<br class="">
<br class="">
Modified: cfe/trunk/lib/Index/IndexBody.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/IndexBody.cpp?rev=262290&r1=262289&r2=262290&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/IndexBody.cpp?rev=262290&r1=262289&r2=262290&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/lib/Index/IndexBody.cpp (original)<br class="">
+++ cfe/trunk/lib/Index/IndexBody.cpp Mon Feb 29 20:46:32 2016<br class="">
@@ -258,7 +258,7 @@ public:<br class="">
DataRecursionQueue *Q = nullptr) {<br class="">
if (E->getOperatorLoc().isInvalid())<br class="">
return true; // implicit.<br class="">
- return base::TraverseCXXOperatorCallExpr(E);<br class="">
+ return base::TraverseCXXOperatorCallExpr(E, Q);<br class="">
}<br class="">
<br class="">
bool VisitDeclStmt(DeclStmt *S) {<br class="">
@@ -325,7 +325,7 @@ public:<br class="">
<br class="">
auto visitForm = [&](InitListExpr *Form) {<br class="">
for (Stmt *SubStmt : Form->children()) {<br class="">
- if (!TraverseStmt(SubStmt))<br class="">
+ if (!TraverseStmt(SubStmt, Q))<br class="">
return false;<br class="">
}<br class="">
return true;<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>