<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 29, 2016 at 8:34 PM, Argyrios Kyrtzidis <span dir="ltr"><<a href="mailto:akyrtzi@gmail.com" target="_blank">akyrtzi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>This is to reduce stack usage, whether it hits stack overflow or not is highly dependent on configuration.</div><div>I've tried forcing smaller stack on the specific test (test/Index/index-many-call-ops.cpp) but then it can hit stack overflow in sema; I don’t have a good way to test this.</div><div>I believe asan was also hitting stack overflow and I’m going to try re-enabling for that test.</div></div></blockquote><div><br></div><div>ah, no worries - yeah, I wouldn't bother with a test for stack size reduction either</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="h5"><br><div><blockquote type="cite"><div>On Feb 29, 2016, at 8:10 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Does this change any behavior? (missing test case?)</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 29, 2016 at 6:46 PM, Argyrios Kyrtzidis via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: akirtzidis<br>
Date: Mon Feb 29 20:46:32 2016<br>
New Revision: 262290<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262290&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262290&view=rev</a><br>
Log:<br>
[index] Fix issue where data visitation was disabled with C++ operator call expressions, during indexing.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Index/IndexBody.cpp<br>
<br>
Modified: cfe/trunk/lib/Index/IndexBody.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/IndexBody.cpp?rev=262290&r1=262289&r2=262290&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/IndexBody.cpp?rev=262290&r1=262289&r2=262290&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Index/IndexBody.cpp (original)<br>
+++ cfe/trunk/lib/Index/IndexBody.cpp Mon Feb 29 20:46:32 2016<br>
@@ -258,7 +258,7 @@ public:<br>
                                    DataRecursionQueue *Q = nullptr) {<br>
     if (E->getOperatorLoc().isInvalid())<br>
       return true; // implicit.<br>
-    return base::TraverseCXXOperatorCallExpr(E);<br>
+    return base::TraverseCXXOperatorCallExpr(E, Q);<br>
   }<br>
<br>
   bool VisitDeclStmt(DeclStmt *S) {<br>
@@ -325,7 +325,7 @@ public:<br>
<br>
     auto visitForm = [&](InitListExpr *Form) {<br>
       for (Stmt *SubStmt : Form->children()) {<br>
-        if (!TraverseStmt(SubStmt))<br>
+        if (!TraverseStmt(SubStmt, Q))<br>
           return false;<br>
       }<br>
       return true;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></blockquote></div><br></div></div>