<div dir="ltr">Could someone provide a feedback?</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature">Thanks,<br>--Serge<br></div></div>
<br><div class="gmail_quote">2016-01-26 20:55 GMT+06:00 Serge Pavlov <span dir="ltr"><<a href="mailto:sepavloff@gmail.com" target="_blank">sepavloff@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sepavloff created this revision.<br>
sepavloff added a subscriber: cfe-commits.<br>
<br>
Declaration of friend function may depend on template parameters,<br>
however it does not become a template function:<br>
<br>
    template<typename T> class C1 {<br>
      friend void func(T x);<br>
    };<br>
<br>
It may be not obvious for user, so compiler could emit a warning in<br>
such case. This patch implements appropriate warning, the wording is<br>
taken from GCC message. The patch fixes PR23342.<br>
<br>
<a href="http://reviews.llvm.org/D16579" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16579</a><br>
<br>
Files:<br>
  include/clang/Basic/DiagnosticGroups.td<br>
  include/clang/Basic/DiagnosticSemaKinds.td<br>
  lib/Sema/SemaDecl.cpp<br>
  test/CXX/drs/dr3xx.cpp<br>
  test/CXX/drs/dr5xx.cpp<br>
  test/CXX/temp/temp.decls/temp.friend/p1.cpp<br>
  test/PCH/cxx-templates.cpp<br>
  test/PCH/cxx-templates.h<br>
  test/SemaCXX/friend.cpp<br>
  test/SemaCXX/overload-call.cpp<br>
<br>
</blockquote></div><br></div>