<div dir="ltr">Ah, good point.  I assumed that the report was valid because they aren't showing up in the doxygen: <a href="http://llvm.org/docs/doxygen/html/classllvm_1_1StringRef.html">http://llvm.org/docs/doxygen/html/classllvm_1_1StringRef.html</a><div><br></div><div>I'll go ahead and revert.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 24, 2016 at 2:06 PM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@gmail.com" target="_blank">benny.kra@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Were you able to reproduce this build failure? ltrim has overloads for<br>
"char" and "StringRef", the former being very new. From the error<br>
message I suspect out of sync LLVM and Clang checkouts.<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, Feb 24, 2016 at 10:55 PM, David Majnemer via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: majnemer<br>
> Date: Wed Feb 24 15:55:58 2016<br>
> New Revision: 261780<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=261780&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=261780&view=rev</a><br>
> Log:<br>
> Don't convert a char to a const char *<br>
><br>
> This fixes PR26728.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/Lex/PPDirectives.cpp<br>
><br>
> Modified: cfe/trunk/lib/Lex/PPDirectives.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/PPDirectives.cpp?rev=261780&r1=261779&r2=261780&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/PPDirectives.cpp?rev=261780&r1=261779&r2=261780&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Lex/PPDirectives.cpp (original)<br>
> +++ cfe/trunk/lib/Lex/PPDirectives.cpp Wed Feb 24 15:55:58 2016<br>
> @@ -1226,7 +1226,7 @@ void Preprocessor::HandleUserDiagnosticD<br>
><br>
>    // Find the first non-whitespace character, so that we can make the<br>
>    // diagnostic more succinct.<br>
> -  StringRef Msg = StringRef(Message).ltrim(' ');<br>
> +  StringRef Msg = StringRef(Message).ltrim(" ");<br>
><br>
>    if (isWarning)<br>
>      Diag(Tok, diag::pp_hash_warning) << Msg;<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>