<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 15, 2016 at 8:05 AM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank" class="cremed">aaron@aaronballman.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sun, Feb 14, 2016 at 11:00 PM, Felix Berger via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" class="cremed">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: flx<br>
> Date: Sun Feb 14 22:00:39 2016<br>
> New Revision: 260872<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=260872&view=rev" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=260872&view=rev</a><br>
> Log:<br>
> Add isAnyPointer() matchers. Register missing matchers.<br>
><br>
> Summary:<br>
> The isAnyPointer() matcher is useful for <a href="http://reviews.llvm.org/D15623" rel="noreferrer" target="_blank" class="cremed">http://reviews.llvm.org/D15623</a>.<br>
><br>
> Reviewers: alexfh, klimek<br>
><br>
> Subscribers: cfe-commits<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D15819" rel="noreferrer" target="_blank" class="cremed">http://reviews.llvm.org/D15819</a><br>
><br>
> Modified:<br>
>     cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h<br>
>     cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp<br>
>     cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h?rev=260872&r1=260871&r2=260872&view=diff" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h?rev=260872&r1=260871&r2=260872&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h (original)<br>
> +++ cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Sun Feb 14 22:00:39 2016<br>
> @@ -3673,6 +3673,19 @@ AST_MATCHER(QualType, isAnyCharacter) {<br>
>      return Node->isAnyCharacterType();<br>
>  }<br>
><br>
> +//// \brief Matches QualType nodes that are of any pointer type.<br>
> +///<br>
> +/// Given<br>
> +/// \code<br>
> +///   int *i = nullptr;<br>
> +///   int j;<br>
> +/// \endcode<br>
> +/// varDecl(hasType(isAnyPointer()))<br>
> +///   matches "int *i", but not "int j".<br>
> +AST_MATCHER(QualType, isAnyPointer) {<br>
> +  return Node->isAnyPointerType();<br>
> +}<br>
<br>
The whole point to isAnyPointer() is for objective C types, where<br>
pointers are modeled differently. Can you add documentation, an<br>
example, and tests for that fact?<br>
<br></blockquote><div><br></div><div>Thanks for making me look into this further. After looking through the existing test cases and matchers I found there is already a pointerType() matcher which is the matcher I originally wanted to expose.</div><div><br></div><div>I can do one of two things now:</div><div><ol><li>Keep the new isAnyPointer() matcher if we think it's useful and add an objc pointer test for it which is already in the works.</li><li>Remove the matcher again since there is no real need for it and users could get the same by writing anyOf(pointerType(), objcObjectPointerType())</li></ol></div><div>What do you think?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
~Aaron<br>
<br>
> +<br>
>  /// \brief Matches QualType nodes that are const-qualified, i.e., that<br>
>  /// include "top-level" const.<br>
>  ///<br>
><br>
> Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp?rev=260872&r1=260871&r2=260872&view=diff" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp?rev=260872&r1=260871&r2=260872&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp (original)<br>
> +++ cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Sun Feb 14 22:00:39 2016<br>
> @@ -264,6 +264,8 @@ RegistryMaps::RegistryMaps() {<br>
>    REGISTER_MATCHER(innerType);<br>
>    REGISTER_MATCHER(integerLiteral);<br>
>    REGISTER_MATCHER(isAnonymous);<br>
> +  REGISTER_MATCHER(isAnyCharacter);<br>
> +  REGISTER_MATCHER(isAnyPointer);<br>
>    REGISTER_MATCHER(isArrow);<br>
>    REGISTER_MATCHER(isBaseInitializer);<br>
>    REGISTER_MATCHER(isCatchAll);<br>
><br>
> Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp?rev=260872&r1=260871&r2=260872&view=diff" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp?rev=260872&r1=260871&r2=260872&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp (original)<br>
> +++ cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp Sun Feb 14 22:00:39 2016<br>
> @@ -1479,6 +1479,14 @@ TEST(IsInteger, ReportsNoFalsePositives)<br>
>                            to(varDecl(hasType(isInteger()))))))));<br>
>  }<br>
><br>
> +TEST(IsAnyPointer, MatchesPointers) {<br>
> +  EXPECT_TRUE(matches("int* i = nullptr;", varDecl(hasType(isAnyPointer()))));<br>
> +}<br>
> +<br>
> +TEST(IsAnyPointer, ReportsNoFalsePositives) {<br>
> +  EXPECT_TRUE(notMatches("int i = 0;", varDecl(hasType(isAnyPointer()))));<br>
> +}<br>
> +<br>
>  TEST(IsAnyCharacter, MatchesCharacters) {<br>
>    EXPECT_TRUE(matches("char i = 0;", varDecl(hasType(isAnyCharacter()))));<br>
>  }<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" class="cremed">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="cremed">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>