<div dir="ltr">should probably have test coverage</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 18, 2016 at 6:46 PM, Eugene Zelenko via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Eugene.Zelenko created this revision.<br>
Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman.<br>
Eugene.Zelenko added a subscriber: cfe-commits.<br>
Eugene.Zelenko set the repository for this revision to rL LLVM.<br>
<br>
While working with LLDB code I noticed that readability-container-size-empty doesn't detect problems with STL string, so this my attempt to fix problem.<br>
<br>
Build and regressions were OK on RHEL 6.<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D17434" rel="noreferrer" target="_blank">http://reviews.llvm.org/D17434</a><br>
<br>
Files:<br>
  clang-tidy/readability/ContainerSizeEmptyCheck.cpp<br>
<br>
Index: clang-tidy/readability/ContainerSizeEmptyCheck.cpp<br>
===================================================================<br>
--- clang-tidy/readability/ContainerSizeEmptyCheck.cpp<br>
+++ clang-tidy/readability/ContainerSizeEmptyCheck.cpp<br>
@@ -16,6 +16,7 @@<br>
<br>
 static bool isContainerName(llvm::StringRef ClassName) {<br>
   static const char *const ContainerNames[] = {"array",<br>
+                                               "basic_string",<br>
                                                "deque",<br>
                                                "forward_list",<br>
                                                "list",<br>
<br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>