<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Feb 10, 2016 at 1:15 PM, Daniel Marjamäki <span dir="ltr"><<a href="mailto:Daniel.Marjamaki@evidente.se" target="_blank">Daniel.Marjamaki@evidente.se</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hello!<br>
<br>
That would make some sense to me.<br>
<br>
To catch portability issues users could use different relevant targets. Do you know if some do that?<br></blockquote><div><br></div><div>They could, but I'm not sure it's a widespread practice to run analysis tools for multiple targets. It's less convenient, requires more resources and something one has specifically set up their development process for. So I think, if this diagnostic could consider a conversion from "int" to "long" (as well as short->int, long->long long, etc.) always a widening conversion and vice versa, it might be useful. I don't know whether it will significantly increase the number of false positives though, but we could try. What do you think?</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
Best regards,<br>
Daniel Marjamäki<br>
<br>
..................................................................................................................<br>
Daniel Marjamäki Senior Engineer<br>
Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden<br>
<br>
Mobile: <a href="tel:%2B46%20%280%29709%2012%2042%2062" value="+46709124262">+46 (0)709 12 42 62</a><br>
E-mail: <a href="mailto:Daniel.Marjamaki@evidente.se">Daniel.Marjamaki@evidente.se</a><br>
<br>
<a href="http://www.evidente.se" rel="noreferrer" target="_blank">www.evidente.se</a><br>
<br>
________________________________________<br>
Från: Alexander Kornienko [<a href="mailto:alexfh@google.com">alexfh@google.com</a>]<br>
</span>Skickat: den 10 februari 2016 12:23<br>
<span class="">Till: Daniel Marjamäki<br>
Kopia: cfe-commits<br>
</span>Ämne: Re: SV: [clang-tools-extra] r260225 - [clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots<br>
<span class=""><br>
Makes sense. I wonder though whether the check should attempt to be platform-independent and warn regardless of whether int and long have the same bit width. What do you think?<br>
<br>
</span><span class="">On Feb 10, 2016 9:35 AM, "Daniel Marjamäki" <<a href="mailto:Daniel.Marjamaki@evidente.se">Daniel.Marjamaki@evidente.se</a><mailto:<a href="mailto:Daniel.Marjamaki@evidente.se">Daniel.Marjamaki@evidente.se</a>>> wrote:<br>
<br>
Hello!<br>
<br>
> I'm not sure this is a good fix. What was the specific issue (and on which buildbots)?<br>
<br>
Ok.<br>
<br>
The buildbots said:<br>
<br>
FileCheck error: '/home/linaro/buildbot/clang-cmake-thumbv7-a15/stage1/tools/clang/tools/extra/test/clang-tidy/Output/misc-misplaced-widening-cast.cpp.tmp.cpp.msg' is empty.<br>
<br>
My check only warns when there is a widening cast. If sizeof(int)==sizeof(long) then there is no warning for a int=>long conversion. In my testcases I tested various int=>long conversions.<br>
<br>
These are the failed builds:<br>
<br>
<a href="http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/187" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/187</a><br>
<a href="http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/6265" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/6265</a><br>
<a href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9641" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9641</a><br>
<a href="http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/9691" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/9691</a><br>
<br>
Best regards,<br>
Daniel Marjamäki<br>
<br>
..................................................................................................................<br>
Daniel Marjamäki Senior Engineer<br>
Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden<br>
<br>
</span>Mobile: <a href="tel:%2B46%20%280%29709%2012%2042%2062" value="+46709124262">+46 (0)709 12 42 62</a><tel:%2B46%20%280%29709%2012%2042%2062><br>
E-mail: <a href="mailto:Daniel.Marjamaki@evidente.se">Daniel.Marjamaki@evidente.se</a><mailto:<a href="mailto:Daniel.Marjamaki@evidente.se">Daniel.Marjamaki@evidente.se</a>><br>
<br>
<a href="http://www.evidente.se" rel="noreferrer" target="_blank">www.evidente.se</a><<a href="http://www.evidente.se" rel="noreferrer" target="_blank">http://www.evidente.se</a>><br>
<br>
________________________________________<br>
Från: Alexander Kornienko [<a href="mailto:alexfh@google.com">alexfh@google.com</a><mailto:<a href="mailto:alexfh@google.com">alexfh@google.com</a>>]<br>
<span class="">Skickat: den 9 februari 2016 17:41<br>
Till: Daniel Marjamäki<br>
Kopia: cfe-commits<br>
Ämne: Re: [clang-tools-extra] r260225 - [clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots<br>
<br>
I'm not sure this is a good fix. What was the specific issue (and on which buildbots)?<br>
<br>
</span><span class="">On Tue, Feb 9, 2016 at 4:43 PM, Daniel Marjamaki via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><mailto:<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>><mailto:<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><mailto:<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>>>> wrote:<br>
Author: danielmarjamaki<br>
Date: Tue Feb 9 09:43:05 2016<br>
New Revision: 260225<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=260225&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=260225&view=rev</a><br>
Log:<br>
[clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots<br>
<br>
Modified:<br>
clang-tools-extra/trunk/test/clang-tidy/misc-misplaced-widening-cast.cpp<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-tidy/misc-misplaced-widening-cast.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/misc-misplaced-widening-cast.cpp?rev=260225&r1=260224&r2=260225&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/misc-misplaced-widening-cast.cpp?rev=260225&r1=260224&r2=260225&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-tidy/misc-misplaced-widening-cast.cpp (original)<br>
+++ clang-tools-extra/trunk/test/clang-tidy/misc-misplaced-widening-cast.cpp Tue Feb 9 09:43:05 2016<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %check_clang_tidy %s misc-misplaced-widening-cast %t<br>
+// RUN: %check_clang_tidy %s misc-misplaced-widening-cast %t -- -- -target x86_64-unknown-unknown<br>
<br>
void assign(int a, int b) {<br>
long l;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
</span><a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><mailto:<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>><mailto:<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><mailto:<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>>><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>