<div dir="ltr">:)<div><br></div><div>We can look at them/deal with them in post-commit review from here on out. No need to block on me.</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Feb 4, 2016 at 6:50 PM Romanova, Katya <<a href="mailto:Katya_Romanova@playstation.sony.com">Katya_Romanova@playstation.sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thank you!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Paul Robinson did a very detailed code review yesterday, so I suspect that this doxygen comment patch is of very good quality.
</span><span style="font-size:11.0pt;font-family:Wingdings;color:#1f497d">J</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Katya.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eric Christopher [mailto:<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>]
<br>
<b>Sent:</b> Thursday, February 04, 2016 6:47 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD16913%2Bpublic%2B13cb39057c4259cd@reviews.llvm.org" target="_blank">reviews+D16913+public+13cb39057c4259cd@reviews.llvm.org</a>; Romanova, Katya; Gao, Yunzhong; <a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a>; <a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>; <a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>; Robinson, Paul<br>
<b>Cc:</b> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<b>Subject:</b> Re: [PATCH] D16913: Adding doxygen comments to the LLVM intrinsics (part 4, pmmintrin.h)<u></u><u></u></span></p>
</div>
</div></div></div></div><div lang="EN-US" link="blue" vlink="purple"><div><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<p class="MsoNormal"><u></u> <u></u></p>
<p>(Without looking)<u></u><u></u></p>
<p>Please go ahead and feel free to commit any documentation to the intrinsic files. :)<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, Feb 4, 2016, 5:59 PM Katya Romanova <<a href="mailto:Katya_Romanova@playstation.sony.com" target="_blank">Katya_Romanova@playstation.sony.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">kromanova created this revision.<br>
kromanova added reviewers: ygao, echristo, jroelofs, gribozavr, craig.topper, probinson.<br>
kromanova added a subscriber: cfe-commits.<br>
kromanova set the repository for this revision to rL LLVM.<br>
<br>
Hello,<br>
<br>
Here is the patch with the doxygen comments for the intrinsincs in the header file pmmintrin.h.<br>
The doxygen comments are automatically generated based on SCE internal intrinsics document using DCG tool that I wrote.<br>
<br>
I will submit more doxygen comments for the other intrinsic header files as soon as this patch is approved.<br>
<br>
Here is the link to the general discussion about adding comments to x86 intrinsics headers.<br>
<a href="http://permalink.gmane.org/gmane.comp.compilers.clang.devel/42032" target="_blank">http://permalink.gmane.org/gmane.comp.compilers.clang.devel/42032</a><br>
<br>
Here are the links to the similar code reviews for the doxygen comments other header files.<br>
<br>
<a href="http://reviews.llvm.org/D8762" target="_blank">http://reviews.llvm.org/D8762</a> (closed)<br>
<a href="http://reviews.llvm.org/D15999" target="_blank">http://reviews.llvm.org/D15999</a> (closed)<br>
<a href="http://reviews.llvm.org/D16562" target="_blank">http://reviews.llvm.org/D16562</a> (closed)<br>
<br>
Katya.<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D16913" target="_blank">http://reviews.llvm.org/D16913</a><br>
<br>
Files:<br>
pmmintrin.h<u></u><u></u></p>
</blockquote>
</div>
</div></div></div></blockquote></div>