<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Sorry.<br>
<br>
Our module builds choke on merging several modules, containing
declarations from STL (we are using libc++, no modulemaps).<br>
<br>
When writing a new module containing the definition of a STL
reverse_iterator, it collects all its template specializations.
Some of the specializations need to be deserialized from a third
module. This triggers an iterator invalidation bug because of the
deserialization happening when iterating the specializations
container itself. This happens only when the container's capacity
is exceeded and the relocation invalidates the iterators and at
best causes a crash (see valgrind reports in the bug report).
Unfortunately I haven't been able to make the reproducer
independent on STL.<br>
<br>
--Vassil<br>
<br>
On 30/01/16 17:08, David Blaikie wrote:<br>
</div>
<blockquote
cite="mid:CAENS6Esc4CM06HZPRcGwFaMhS2HZkweEFAhq-S0KKcavGHQq+w@mail.gmail.com"
type="cite">
<p dir="ltr">It might be handy to give an overview of the issue in
the review (& certainly in the commit) message rather than
only citing the bug number</p>
<div class="gmail_quote">On Jan 30, 2016 6:49 AM, "Vassil Vassilev
via cfe-commits" <<a moz-do-not-send="true"
href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Attaching a
fix to <a moz-do-not-send="true"
href="https://llvm.org/bugs/show_bug.cgi?id=26237"
rel="noreferrer" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=26237</a><br>
<br>
Please review.<br>
<br>
Many thanks!<br>
--Vassil<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits"
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>